acer-wmi uses input:i8042_command() => build error

acer-wmi uses input:i8042_command() => build error

[Randy Dunlap]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

drivers/built-in.o: In function `set_u32':
acer-wmi.c:(.text+0xb9bf6): undefined reference to `i8042_command'
make[1]: *** [vmlinux] Error 1
make: *** [sub-make] Error 2

config attached.

---
~Randy

[-- Attachment #2: r9a.config --]
[-- Type: application/x-config, Size: 28585 bytes --]

Re: acer-wmi uses input:i8042_command() => build error

[Carlos Corbacho]

On Monday 10 March 2008 19:47:54 Randy Dunlap wrote:
> drivers/built-in.o: In function `set_u32':
> acer-wmi.c:(.text+0xb9bf6): undefined reference to `i8042_command'
> make[1]: *** [vmlinux] Error 1
> make: *** [sub-make] Error 2

It appears acer-wmi also depends on CONFIG_SERIO_I8042 for that function (I 
don't have CONFIG_EMBEDDED set so didn't notice that it could be disabled on 
x86).

-Carlos
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D

Re: acer-wmi uses input:i8042_command() => build error

[Jiri Kosina]

On Mon, 10 Mar 2008, Randy Dunlap wrote:

> drivers/built-in.o: In function `set_u32':
> acer-wmi.c:(.text+0xb9bf6): undefined reference to `i8042_command'
> make[1]: *** [vmlinux] Error 1
> make: *** [sub-make] Error 2

Does the patch below fix your build?


From: Jiri Kosina <jkosina@suse.cz>

Acer-wmi dependends on i8042 code.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

--- 
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 982e27b..962817e 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -108,6 +108,7 @@ config ACER_WMI
 	depends on ACPI
 	depends on LEDS_CLASS
 	depends on BACKLIGHT_CLASS_DEVICE
+	depends on SERIO_I8042
 	select ACPI_WMI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds

Re: acer-wmi uses input:i8042_command() => build error

[Randy Dunlap]

On Mon, 10 Mar 2008 22:29:37 +0100 (CET) Jiri Kosina wrote:

> On Mon, 10 Mar 2008, Randy Dunlap wrote:
> 
> > drivers/built-in.o: In function `set_u32':
> > acer-wmi.c:(.text+0xb9bf6): undefined reference to `i8042_command'
> > make[1]: *** [vmlinux] Error 1
> > make: *** [sub-make] Error 2
> 
> Does the patch below fix your build?

Yes, thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>


> From: Jiri Kosina <jkosina@suse.cz>
> 
> Acer-wmi dependends on i8042 code.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> --- 
>  drivers/misc/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 982e27b..962817e 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -108,6 +108,7 @@ config ACER_WMI
>  	depends on ACPI
>  	depends on LEDS_CLASS
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on SERIO_I8042
>  	select ACPI_WMI
>  	---help---
>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
> --

---
~Randy

Re: acer-wmi uses input:i8042_command() => build error

[Carlos Corbacho]

On Monday 10 March 2008 23:06:49 Randy Dunlap wrote:
> Yes, thanks.
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>

(I'll add this to my queue, although given my last set of patches hasn't been 
applied to the ACPI tree yet, and Len seems to have gone AWOL for the last 
two weeks since then, I have no idea on the chances of this getting in, 
unless someone else wants to pick it up?)

-Carlos
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D

Re: acer-wmi uses input:i8042_command() => build error

[Jiri Kosina]

On Mon, 10 Mar 2008, Carlos Corbacho wrote:

> Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
> (I'll add this to my queue, although given my last set of patches hasn't been 
> applied to the ACPI tree yet, and Len seems to have gone AWOL for the last 
> two weeks since then, I have no idea on the chances of this getting in, 
> unless someone else wants to pick it up?)

Probably just Sign it off and bounce it to Andrew, he'll manage.

Thanks,

-- 
Jiri Kosina

Re: acer-wmi uses input:i8042_command() => build error

[Len Brown]

On Monday 10 March 2008, Carlos Corbacho wrote:
> Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>

applied.
thanks,

-len