From: Len Brown <lenb@kernel.org>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: "Zhang, Rui" <rui.zhang@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>,
"Lin, Ming M" <ming.m.lin@intel.com>,
robert.moore@intel.com, davej@redhat.com
Subject: Re: [PATCH] ACPI: disable stray gpe correctly
Date: Wed, 12 Mar 2008 16:09:45 -0400 [thread overview]
Message-ID: <200803121609.46134.lenb@kernel.org> (raw)
In-Reply-To: <47D8351F.7080802@redhat.com>
> > On Sunday 09 March 2008, Zhang, Rui wrote:
> >> Disable stray GPE correctly
> >> https://bugzilla.redhat.com/show_bug.cgi?id=251744
> >> http://bugzilla.kernel.org/show_bug.cgi?id=6217
> >>
> >> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
> >> ---
> >> drivers/acpi/events/evgpe.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> Index: linux-2.6/drivers/acpi/events/evgpe.c
> >> ===================================================================
> >> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
> >> +++ linux-2.6/drivers/acpi/events/evgpe.c
> >> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
> >>
> >> ACPI_FUNCTION_TRACE(ev_disable_gpe);
> >>
> >> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
> >> + if (gpe_event_info->flags &&
> >> + (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK))) {
> >> return_ACPI_STATUS(AE_OK);
> >> }
> >>
>
> Causes ACPI battery problems...
>
> https://bugzilla.redhat.com/show_bug.cgi?id=436959
Okay, i've droppped it until 436959 can be figured out.
thanks Chuck,
-Len
next prev parent reply other threads:[~2008-03-12 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 2:04 [PATCH] ACPI: disable stray gpe correctly Zhang, Rui
2008-03-11 6:06 ` Len Brown
2008-03-12 19:55 ` Chuck Ebbert
2008-03-12 20:09 ` Len Brown [this message]
2008-03-12 21:59 ` Moore, Robert
2008-03-12 22:35 ` Chuck Ebbert
2008-03-14 21:48 ` Moore, Robert
2008-03-17 2:09 ` Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803121609.46134.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=cebbert@redhat.com \
--cc=davej@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox