From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [RFC] fix asus_hides_smbus_lpc_ich6() for resume Date: Fri, 14 Mar 2008 06:26:02 -0600 Message-ID: <20080314122601.GQ613@parisc-linux.org> References: <1205466549.5127.2.camel@sli10-desk.sh.intel.com> <20080314044408.GB17961@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:47614 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbYCNM0S (ORCPT ); Fri, 14 Mar 2008 08:26:18 -0400 Content-Disposition: inline In-Reply-To: <20080314044408.GB17961@suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Greg KH Cc: Shaohua Li , linux acpi , linux-pci , Len Brown , "Rafael J. Wysocki" On Thu, Mar 13, 2008 at 09:44:08PM -0700, Greg KH wrote: > And why "_later"? What's wrong with the normal resume time? He said: > asus_hides_smbus_lpc_ich6() is called with interrupt disabled in resume > time, but ioremap_nocache() and iounmap() can't be called with interrupt > disabled. Below is my debug fix. If you have better fix, please speak. Maybe _resume is run too early and could be run later when interrupts are enabled? But I haven't looked into that at all. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."