Re: [RFC] fix asus_hides_smbus_lpc_ich6() for resume

Shaohua Li
2008-03-18T03:13:54Z

On Mon, 2008-03-17 at 21:39 +0000, Sergio Monteiro Basto wrote:
> On Mon, 2008-03-17 at 03:40 +0000, Sergio Monteiro Basto wrote:
> > On Fri, 2008-03-14 at 11:49 +0800, Shaohua Li wrote:
> > > asus_hides_smbus_lpc_ich6() is called with interrupt disabled in
> > > resume
> > > time, but ioremap_nocache() and iounmap() can't be called with
> > > interrupt
> > > disabled. Below is my debug fix. If you have better fix, please
> > > speak.
> >
> > yap , I have a better fix for my laptop
> > I have a Compaq nx , and this quirk is applied ,
> >
> > I simply remove the quirk like I had write
> > http://lkml.org/lkml/2007/3/9/516
> >
> > Especially if we don't an ASUS, which may need the quirk.
> >
> > I have been working almost an year without the quirk on my laptop and
> > things seems that work better
>
> Btw I am running 2.6.24.3-12 fedora kernel , I recompile from the
> src.rpm and apply with 2 patches one:
> http://bugzilla.kernel.org/show_bug.cgi?id=9642
> this one seems that I don't need anymore on 2.6.25-rc
> and remove this quirk.
> And enable ACPI_DEBUG.
>
> And I am very happy with it , hibernation, suspend works very well and
> don't loose ACPI events after resume, backlight also works always fine,
> ACPI events always on, resume from ram don't have to go to console to
> have screen .
> I just use git Intel drive.
>
> Which make me think, will not updates kernels for a very long time :)
> Regards,
Sure, you can remove the quirk without any problem if you don't want to
use the smbus device.

Thanks,
Shaohua