From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Greg KH <gregkh@suse.de>, Shaohua Li <shaohua.li@intel.com>,
linux acpi <linux-acpi@vger.kernel.org>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
Len Brown <lenb@kernel.org>
Subject: Re: [RFC] fix asus_hides_smbus_lpc_ich6() for resume
Date: Fri, 14 Mar 2008 16:44:25 +0100 [thread overview]
Message-ID: <200803141644.26412.rjw@sisk.pl> (raw)
In-Reply-To: <20080314144300.GS613@parisc-linux.org>
On Friday, 14 of March 2008, Matthew Wilcox wrote:
> On Fri, Mar 14, 2008 at 03:34:34PM +0100, Rafael J. Wysocki wrote:
> > On Friday, 14 of March 2008, Matthew Wilcox wrote:
> > > On Thu, Mar 13, 2008 at 09:44:08PM -0700, Greg KH wrote:
> > > > And why "_later"? What's wrong with the normal resume time?
> > >
> > > He said:
> > > > asus_hides_smbus_lpc_ich6() is called with interrupt disabled in resume
> > > > time, but ioremap_nocache() and iounmap() can't be called with interrupt
> > > > disabled. Below is my debug fix. If you have better fix, please speak.
> > >
> > > Maybe _resume is run too early and could be run later when interrupts
> > > are enabled?
> >
> > That's what Shaohua is trying to achieve, AFAICS.
>
> Shaohua is adding an extra class of resume_later fixups and moving this
> one to it. I'm saying that maybe resume fixups should all be run later.
Yes, I thought about that too.
> But I haven't looked at the dependencies here. That may not be possible.
Well, I'm not sure how to find out (reliably) who uses it.
next prev parent reply other threads:[~2008-03-14 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 3:49 [RFC] fix asus_hides_smbus_lpc_ich6() for resume Shaohua Li
2008-03-14 4:44 ` Greg KH
2008-03-14 7:50 ` Shaohua Li
2008-03-14 14:37 ` Rafael J. Wysocki
2008-03-14 17:15 ` Jesse Barnes
2008-03-14 21:03 ` Rafael J. Wysocki
2008-03-17 1:15 ` Shaohua Li
2008-03-17 16:26 ` Rafael J. Wysocki
2008-03-18 3:11 ` Shaohua Li
2008-04-16 17:30 ` Rafael J. Wysocki
2008-04-17 2:16 ` Shaohua Li
2008-03-14 12:26 ` Matthew Wilcox
2008-03-14 14:34 ` Rafael J. Wysocki
2008-03-14 14:43 ` Matthew Wilcox
2008-03-14 15:44 ` Rafael J. Wysocki [this message]
2008-03-14 17:14 ` Jesse Barnes
2008-03-17 3:40 ` Sergio Monteiro Basto
2008-03-17 21:39 ` Sergio Monteiro Basto
2008-03-18 3:14 ` Shaohua Li
2008-03-18 23:47 ` Sergio Monteiro Basto
2008-04-06 2:05 ` Sergio Monteiro Basto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803141644.26412.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=gregkh@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox