From: Pavel Machek <pavel@ucw.cz>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Len Brown <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: ACPI lockdep warning on boot, 2.6.25-rc5
Date: Sat, 15 Mar 2008 14:16:11 +0100 [thread overview]
Message-ID: <20080315131611.GA4828@ucw.cz> (raw)
In-Reply-To: <20080314001819.GA32584@linux-os.sc.intel.com>
Hi!
> @@ -421,7 +423,9 @@
> else
> acpi_safe_halt();
>
> - local_irq_enable();
> + if (irqs_disabled())
> + local_irq_enable();
> +
> return;
> }
>
> @@ -530,7 +534,9 @@
> * skew otherwise.
> */
> sleep_ticks = 0xFFFFFFFF;
> - local_irq_enable();
> + if (irqs_disabled())
> + local_irq_enable();
> +
> break;
>
> case ACPI_STATE_C2:
That's pretty ugly. Could the code be modified to have interrupt
consistent at this point?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-03-15 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 10:33 ACPI lockdep warning on boot, 2.6.25-rc5 Miklos Szeredi
2008-03-12 22:01 ` Rafael J. Wysocki
2008-03-13 20:14 ` Len Brown
2008-03-14 0:18 ` Venki Pallipadi
2008-03-14 4:07 ` Len Brown
2008-03-15 13:16 ` Pavel Machek [this message]
2008-03-19 20:09 ` Venki Pallipadi
2008-03-19 20:51 ` Rafael J. Wysocki
2008-04-18 10:24 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080315131611.GA4828@ucw.cz \
--to=pavel@ucw.cz \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rjw@sisk.pl \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox