From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks Date: Wed, 19 Mar 2008 00:54:57 +0100 Message-ID: <20080318235457.GA1936@elf.ucw.cz> References: <20080318100106.GA10830@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Alan Stern Cc: LKML , ACPI Devel Maling List , pm list , Alexey Starikovskiy List-Id: linux-acpi@vger.kernel.org Hi! > > So... we do prepare() but it detects new child, so it returns -EAGAIN. > > so we call complete() based on description above > > ...and then we call prepare() to suspend again? > > You misunderstood (maybe the comment needs to be clarified as above). Yes, please :-). > If prepare() returns any error (including -EAGAIN) then complete() does > not get called. If prepare() returns successfully but the PM core > detects that a new child was added while prepare() was running, then we > call complete(), suspend the child, and call prepare() again. Ok. > > > + * @suspend: Executed before putting the system into a sleep state in which the > > > + * contents of main memory are preserved. Quiesce the device, put it into > > > > content....is? > > It's okay to use "contents" -- analogous to the table of contents in a > book. It's one of those weird corner cases where either alternative is > acceptable. Ok -- I guess I should get that english course ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/