Re: [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI bus type

Greg KH
2008-03-19T18:06:35Z

On Wed, Mar 19, 2008 at 02:24:48PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, 19 of March 2008, Greg KH wrote:
> > On Mon, Mar 17, 2008 at 12:25:15AM +0100, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > Implement new suspend and hibernation callbacks for the PCI busi type.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > > ---
> > > drivers/pci/pci-driver.c | 497 ++++++++++++++++++++++++++++++++++++++++++-----
> > > include/linux/pci.h | 2
> > > 2 files changed, 453 insertions(+), 46 deletions(-)
> >
> > Hm, that's a lot of code added. What additional functionality did we
> > just get?
>
> The possibility to handle suspend/hibernation in a more flexible way, provided
> that the drivers define the new callbacks.

So, we're going to have to now convert all drivers, right? Nice, I can
always use a bump up in the "number of patches submited" numbers :)

thanks,

greg k-h