Re: [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI bus type

Rafael J. Wysocki
2008-03-19T13:24:48Z

On Wednesday, 19 of March 2008, Greg KH wrote:
> On Mon, Mar 17, 2008 at 12:25:15AM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Implement new suspend and hibernation callbacks for the PCI busi type.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > drivers/pci/pci-driver.c | 497 ++++++++++++++++++++++++++++++++++++++++++-----
> > include/linux/pci.h | 2
> > 2 files changed, 453 insertions(+), 46 deletions(-)
>
> Hm, that's a lot of code added. What additional functionality did we
> just get?

The possibility to handle suspend/hibernation in a more flexible way, provided
that the drivers define the new callbacks.

> Are we going to have to create a noirq version for every driver and bus
> type now?

No, we aren't. The PCI and platform bus types already have the noirq callbacks
implemented (they are called _late and _early, but that's the same
essentially).

Thanks,
Rafael