Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks

Greg KH
2008-03-19T00:53:40Z

On Mon, Mar 17, 2008 at 12:22:29AM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Introduce 'struct pm_ops' representing a set of suspend and
> hibernation operations for bus types, device classes and device
> types.

Ok, I must have missed the thread describing why we need to do this, so,
why do we need to do this? What is this going to buy us in the end
after everything is changed?

> +struct pm_ops {
> +#ifdef CONFIG_PM_SLEEP
> + int (*prepare)(struct device *dev);
> + void (*complete)(struct device *dev);
> +#endif
> +#ifdef CONFIG_SUSPEND
> + int (*suspend)(struct device *dev);
> + int (*resume)(struct device *dev);
> +#endif
> +#ifdef CONFIG_HIBERNATION
> + int (*freeze)(struct device *dev);
> + int (*thaw)(struct device *dev);
> + int (*poweroff)(struct device *dev);
> + int (*quiesce)(struct device *dev);
> + int (*restore)(struct device *dev);
> + int (*recover)(struct device *dev);
> +#endif

Don't ifdef stuff like this, it only causes ifdefs to be needed to the
.c code as well for all places these structures are defined in
drivers/busses, right?

thanks,

greg k-h