From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Chiang Subject: Re: [PATCH 3/16][BUG] ACPI pci_slot: Fix _STA evaluation (Not for mainline!) Date: Fri, 21 Mar 2008 10:17:39 -0600 Message-ID: <20080321161739.GG17292@ldl.fc.hp.com> References: <20080318210539.GA30421@ldl.fc.hp.com> <47E33472.1000602@jp.fujitsu.com> <47E3356D.6010509@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from g5t0008.atlanta.hp.com ([15.192.0.45]:42190 "EHLO g5t0008.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbYCUQRk (ORCPT ); Fri, 21 Mar 2008 12:17:40 -0400 Content-Disposition: inline In-Reply-To: <47E3356D.6010509@jp.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Kenji Kaneshige Cc: Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org * Kenji Kaneshige : > Fix the problem that pci slots that doesn't have _STA are not > detected. If the device doesn't have _STA, we must assume it is always > there. Merged, thanks. /ac > > Signed-off-by: Kenji Kaneshige > --- > drivers/acpi/pci_slot.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > Index: linux-2.6.25-rc6/drivers/acpi/pci_slot.c > =================================================================== > --- linux-2.6.25-rc6.orig/drivers/acpi/pci_slot.c > +++ linux-2.6.25-rc6/drivers/acpi/pci_slot.c > @@ -76,9 +76,8 @@ check_slot(acpi_handle handle, int *devi > > if (check_sta_before_sun) { > /* If SxFy doesn't have _STA, we just assume it's there */ > - acpi_evaluate_integer(handle, "_STA", NULL, &sta); > - > - if (!(sta & ACPI_STA_DEVICE_PRESENT)) { > + status = acpi_evaluate_integer(handle, "_STA", NULL, &sta); > + if (ACPI_SUCCESS(status) && !(sta & ACPI_STA_DEVICE_PRESENT)) { > retval = -1; > goto out; > } > >