From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Chiang Subject: Re: [PATCH 15/16] PCI slot: Trivial cleanups for slot.c (Not for mainline!) Date: Mon, 24 Mar 2008 21:31:35 -0600 Message-ID: <20080325033135.GD26434@ldl.fc.hp.com> References: <20080318210539.GA30421@ldl.fc.hp.com> <47E33472.1000602@jp.fujitsu.com> <47E3390A.7030308@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from g4t0016.houston.hp.com ([15.201.24.19]:37478 "EHLO g4t0016.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757320AbYCYDbg (ORCPT ); Mon, 24 Mar 2008 23:31:36 -0400 Content-Disposition: inline In-Reply-To: <47E3390A.7030308@jp.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Kenji Kaneshige Cc: Greg KH , Gary Hade , Kristen Carlson Accardi , Matthew Wilcox , warthog19@eaglescrag.net, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org * Kenji Kaneshige : > Some trivial cleanups for drivers/pci/slot.c. Thanks, merged. /ac > > Signed-off-by: Kenji Kaneshige > > --- > drivers/pci/slot.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > Index: linux-2.6.25-rc6/drivers/pci/slot.c > =================================================================== > --- linux-2.6.25-rc6.orig/drivers/pci/slot.c > +++ linux-2.6.25-rc6/drivers/pci/slot.c > @@ -132,19 +132,16 @@ EXPORT_SYMBOL_GPL(pci_destroy_slot); > > static int pci_slot_init(void) > { > - int result = 0; > struct kset *pci_bus_kset; > > pci_bus_kset = bus_get_kset(&pci_bus_type); > - > pci_slots_kset = kset_create_and_add("slots", NULL, > &pci_bus_kset->kobj); > if (!pci_slots_kset) { > - result = -ENOMEM; > - printk(KERN_ERR "PCI: Slot initialization failure (%d)\n", > - result); > + printk(KERN_ERR "PCI: Slot initialization failure\n"); > + return -ENOMEM; > } > - return result; > + return 0; > } > > subsys_initcall(pci_slot_init); > >