ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6)

Len Brown
2008-03-26T15:34:11Z

> btw., saw this ACPI-ish commit in rc7:
>
> | commit b97d4803400a4442b0e4ae14d0bd8e83994b9004
> | Author: Bjorn Helgaas <bjorn.helgaas@hp.com>
> | Date: Tue Mar 25 11:21:11 2008 -0600
> |
> | ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA")
>
> a grep shows that we've got one other case of an "ISA" string in the
> ACPI code - is the patch below needed too?
>
> Ingo
>
> -------------------->
> Subject: acpi: fix asus isa
> From: Ingo Molnar <mingo@elte.hu>
> Date: Wed Mar 26 09:05:07 CET 2008
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> drivers/acpi/asus_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-x86.q/drivers/acpi/asus_acpi.c
> ===================================================================
> --- linux-x86.q.orig/drivers/acpi/asus_acpi.c
> +++ linux-x86.q/drivers/acpi/asus_acpi.c
> @@ -149,7 +149,7 @@ struct asus_hotk {
> };
>
> /* Here we go */
> -#define A1x_PREFIX "\\_SB.PCI0.ISA.EC0."
> +#define A1x_PREFIX "\\_SB.PCI0.ISA_.EC0."

>From an AML point of view, ISA is just as legal as "ISA_"
The NameString paramter to Device() can be 1 to 4 characters.

So if this is correct or not depends on what the BIOS programmer
for the Asus A1x choose to write. Perhaps Corentin 'Iksaif' CHARY
can confirm if the driver is working properly on that system.

-Len

> #define L3C_PREFIX "\\_SB.PCI0.PX40.ECD0."
> #define M1A_PREFIX "\\_SB.PCI0.PX40.EC0."
> #define P30_PREFIX "\\_SB.PCI0.LPCB.EC0."
>