From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: [patch 02/37] PNPACPI: continue after _CRS and _PRS errors Date: Wed, 26 Mar 2008 11:11:00 -0600 Message-ID: <20080326171223.669628073@ldl.fc.hp.com> References: <20080326171058.099442579@ldl.fc.hp.com> Return-path: Content-Disposition: inline; filename=pnpacpi-ignore-errors Sender: linux-kernel-owner@vger.kernel.org To: Len Brown Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Belay , Li Shaohua , Matthieu Castet , Thomas Renninger , Rene Herman , Jaroslav Kysela , Andrew Morton List-Id: linux-acpi@vger.kernel.org Keep going and register the device even if we have trouble parsing _CRS or _PRS. A parsing problem might mean we ignore some resources the device is using, or we might not be able to change its resources. But we should still take note of anything we *could* parse correctly. Also remove reference to dev_id because I plan to remove it soon. Signed-off-by: Bjorn Helgaas Index: work7/drivers/pnp/pnpacpi/core.c =================================================================== --- work7.orig/drivers/pnp/pnpacpi/core.c 2008-03-21 15:12:19.000000000 -0600 +++ work7/drivers/pnp/pnpacpi/core.c 2008-03-21 15:12:20.000000000 -0600 @@ -213,8 +213,7 @@ &dev->res); if (ACPI_FAILURE(status) && (status != AE_NOT_FOUND)) { pnp_err("PnPACPI: METHOD_NAME__CRS failure for %s", - dev_id->id); - goto err1; + acpi_device_hid(device)); } } @@ -223,8 +222,7 @@ dev); if (ACPI_FAILURE(status) && (status != AE_NOT_FOUND)) { pnp_err("PnPACPI: METHOD_NAME__PRS failure for %s", - dev_id->id); - goto err1; + acpi_device_hid(device)); } } @@ -252,8 +250,6 @@ num++; return AE_OK; -err1: - kfree(dev_id); err: kfree(dev); return -EINVAL; --