From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Greg KH <greg@kroah.com>, Len Brown <lenb@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
David Brownell <david-b@pacbell.net>, Pavel Machek <pavel@ucw.cz>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4)
Date: Thu, 27 Mar 2008 17:24:57 +0100 [thread overview]
Message-ID: <200803271724.59155.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0803262305580.21714-100000@netrider.rowland.org>
On Thursday, 27 of March 2008, Alan Stern wrote:
> On Thu, 27 Mar 2008, Rafael J. Wysocki wrote:
>
> > @@ -68,22 +75,32 @@ int device_pm_add(struct device *dev)
> > dev->bus ? dev->bus->name : "No Bus",
> > kobject_name(&dev->kobj));
> > mutex_lock(&dpm_list_mtx);
> > - if ((dev->parent && dev->parent->power.sleeping) || all_sleeping) {
> > - if (dev->parent->power.sleeping)
> > - dev_warn(dev,
> > - "parent %s is sleeping, will not add\n",
> > + if (dev->parent) {
> > + if (dev->parent->power.status >= DPM_SUSPENDING) {
> > + dev_warn(dev, "parent %s is sleeping, will not add\n",
> > dev->parent->bus_id);
>
> You forgot to check for dev->parent->power.status == DPM_INVALID.
Right, will fix.
Thanks,
Rafael
next prev parent reply other threads:[~2008-03-27 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 22:53 [RFC][PATCH 0/3] PM: Rework suspend and hibernation code for devices (rev. 2) Rafael J. Wysocki
2008-03-26 23:03 ` [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4) Rafael J. Wysocki
2008-03-26 23:27 ` Alexey Starikovskiy
2008-03-26 23:43 ` Benjamin Herrenschmidt
2008-03-26 23:54 ` Rafael J. Wysocki
2008-03-27 0:06 ` Benjamin Herrenschmidt
2008-03-27 1:23 ` Rafael J. Wysocki
2008-03-27 2:52 ` Benjamin Herrenschmidt
2008-03-27 16:33 ` Rafael J. Wysocki
2008-03-26 23:59 ` Rafael J. Wysocki
2008-03-27 1:12 ` Rafael J. Wysocki
2008-03-27 3:09 ` Alan Stern
2008-03-27 16:24 ` Rafael J. Wysocki [this message]
2008-03-26 23:05 ` [RFC][PATCH 2/3] PM: New suspend and hibernation callbacks for platform bus type (rev. 2) Rafael J. Wysocki
2008-03-26 23:06 ` [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803271724.59155.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=astarikovskiy@suse.de \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=oliver@neukum.org \
--cc=pavel@ucw.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox