From: akpm@linux-foundation.org
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org,
dag@bakke.com, arjan@infradead.org
Subject: [patch 1/1] acpi: enable C3 Power State on Dell Inspiron 8200
Date: Fri, 28 Mar 2008 14:17:21 -0700 [thread overview]
Message-ID: <200803282117.m2SLHLI0010417@imap1.linux-foundation.org> (raw)
From: Dag Bakke <dag@bakke.com>
Taken from http://bugzilla.kernel.org/show_bug.cgi?id=8703
[akpm@linux-foundation.org: fix warning]
Tested-by: Arjan van de Ven <arjan@infradead.org>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/acpi/processor_idle.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff -puN drivers/acpi/processor_idle.c~acpi-enable-c3-power-state-on-dell-inspiron-8200 drivers/acpi/processor_idle.c
--- a/drivers/acpi/processor_idle.c~acpi-enable-c3-power-state-on-dell-inspiron-8200
+++ a/drivers/acpi/processor_idle.c
@@ -103,6 +103,8 @@ static unsigned int latency_factor __rea
module_param(latency_factor, uint, 0644);
#endif
+static int forced_c3;
+
/*
* IBM ThinkPad R40e crashes mysteriously when going into C2 or C3.
* For now disable this. Probably a bug somewhere else.
@@ -123,6 +125,19 @@ static int set_max_cstate(const struct d
return 0;
}
+/*
+ * Some (Dell) machines set the C3 latency to a value which effectively says:
+ * "Don't use C3." Still, C3 works if we force it.
+ * This enables C3 on Dell Inspiron 8200 machines.
+ */
+static int dmi_force_c3(const struct dmi_system_id *id)
+{
+ forced_c3 = 1;
+ printk(KERN_NOTICE PREFIX "%s detected - Force enabling C3.",
+ id->ident);
+ return 0;
+}
+
/* Actually this shouldn't be __cpuinitdata, would be better to fix the
callers to only run once -AK */
static struct dmi_system_id __cpuinitdata processor_power_dmi_table[] = {
@@ -181,6 +196,9 @@ static struct dmi_system_id __cpuinitdat
DMI_MATCH(DMI_BIOS_VENDOR,"Phoenix Technologies LTD"),
DMI_MATCH(DMI_BIOS_VERSION,"SHE845M0.86C.0013.D.0302131307")},
(void *)2},
+ { dmi_force_c3, "Dell Inspiron 8200", {
+ DMI_MATCH(DMI_SYS_VENDOR,"Dell Computer Corporation"),
+ DMI_MATCH(DMI_PRODUCT_NAME,"Inspiron 8200") }, NULL},
{},
};
@@ -1047,11 +1065,12 @@ static void acpi_processor_power_verify_
* C3 latency must be less than or equal to 1000
* microseconds.
*/
- else if (cx->latency > ACPI_PROCESSOR_MAX_C3_LATENCY) {
+ if (cx->latency > ACPI_PROCESSOR_MAX_C3_LATENCY && !forced_c3) {
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
"latency too large [%d]\n", cx->latency));
return;
- }
+ } else if (forced_c3)
+ cx->latency = ACPI_PROCESSOR_MAX_C3_LATENCY;
/*
* PIIX4 Erratum #18: We don't support C3 when Type-F (fast)
_
reply other threads:[~2008-03-28 21:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803282117.m2SLHLI0010417@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=dag@bakke.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox