From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [RFC][PATCH 1/3] use new pm_ops in DRM drivers Date: Thu, 3 Apr 2008 16:48:59 -0700 Message-ID: <200804031648.59630.jbarnes@virtuousgeek.org> References: <200804020207.40278.rjw@sisk.pl> <200804031150.55967.jbarnes@virtuousgeek.org> <1207259267.10388.334.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from outbound-mail-143.bluehost.com ([67.222.38.33]:49944 "HELO outbound-mail-143.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754766AbYDCXun (ORCPT ); Thu, 3 Apr 2008 19:50:43 -0400 In-Reply-To: <1207259267.10388.334.camel@pasglop> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: benh@kernel.crashing.org Cc: "Rafael J. Wysocki" , pm list , ACPI Devel Maling List , Alan Stern , Greg KH , Len Brown , LKML , Alexey Starikovskiy , David Brownell , Pavel Machek , Oliver Neukum , Nigel Cunningham , Dave Airlie On Thursday, April 03, 2008 2:47 pm Benjamin Herrenschmidt wrote: > On Thu, 2008-04-03 at 11:50 -0700, Jesse Barnes wrote: > > +static struct pm_ops i915_pm_ops = { > > + .prepare = NULL, /* DRM core should prevent any new ioctls? */ > > + .complete = NULL, /* required to re-enable DRM client requests > > */ > > The DRM core could definitely provide generic prepare & complete that > sync'up with user space, making sure the command streams stop etc... Yeah, that's what I had in mind. I'll have to think a little harder about it though, I think there may be some driver specific stuff required here as well, which would mean a driver routine that calls into a core routine (both of which still need to be written :). Jesse