From: David Brownell <david-b@pacbell.net>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: "Zhang, Rui" <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org, lenb@kernel.org,
Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [RFC] [PATCH 1/3] Allow to override the RTC alarm time
Date: Thu, 10 Apr 2008 20:46:47 -0700 [thread overview]
Message-ID: <200804102046.48082.david-b@pacbell.net> (raw)
In-Reply-To: <1207911866.9448.34.camel@yakui_zhao.sh.intel.com>
On Friday 11 April 2008, Zhao Yakui wrote:
> But The following is reasonable. IMO.
> For October: 0x0A will be written into the RTC region
> (MONTH_ALARM). But in fact 0x10 should be written.
> /* Writing 0xff means "don't care" or "match all". */
>
> - mon = t->time.tm_mon;
> - mon = (mon < 12) ? BIN2BCD(mon) : 0xff;
> - mon++;
> + mon = t->time.tm_mon + 1;
> + mon = (mon <= 12) ? BIN2BCD(mon) : 0xff;
>
> Is there an opportunity to merge it?
Sure. Submit that as a patch by itself.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-11 3:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-09 6:34 [RFC] [PATCH 1/3] Allow to override the RTC alarm time Zhao Yakui
2008-04-09 7:34 ` David Brownell
2008-04-09 7:46 ` Zhang, Rui
2008-04-09 8:27 ` David Brownell
2008-04-09 16:55 ` Zhao Yakui
2008-04-09 10:13 ` David Brownell
2008-04-10 11:08 ` Zhao Yakui
2008-04-11 5:13 ` David Brownell
2008-04-11 11:04 ` Zhao Yakui
2008-04-11 3:46 ` David Brownell [this message]
2008-04-11 12:44 ` Zhao Yakui
2008-04-11 5:12 ` David Brownell
2008-04-11 6:30 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804102046.48082.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alessandro.zummo@towertech.it \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox