From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: matthieu castet <castet.matthieu@free.fr>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] check that acpi_wakeup_address is below 1MB v2
Date: Fri, 11 Apr 2008 17:12:23 +0200 [thread overview]
Message-ID: <200804111712.24233.rjw@sisk.pl> (raw)
In-Reply-To: <1207907709.9448.19.camel@yakui_zhao.sh.intel.com>
On Friday, 11 of April 2008, Zhao Yakui wrote:
> On Thu, 2008-04-10 at 23:33 +0200, matthieu castet wrote:
> > Hi,
> >
> > this patch add a check that the memory allocated for s3 wakeup is in the
> > first 1MB as required by acpi spec.
> >
> Have you found whether some systems are afflicted by this ?
>
> In fact that OS allacates the acpi_wake_address follows the below two
> functions:
> reserve_bootmem(0, PAGE_SIZE, BOOTMEM_DEFAULT);
> reserve_bootmem(PAGE_SIZE, PAGE_SIZE, BOOTMEM_DEFAULT);
>
> The above mechanism can insure that the acpi_wake_address is in memroy
> below 1M. (It is unncessary to apply the patch. IMO)
Agreed.
> Of course the addressing check will be more strict after this patch is
> applied.
Matthieu, can you please explain why you consider the patch as necessary?
Thanks,
Rafael
next prev parent reply other threads:[~2008-04-11 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 21:33 [PATCH] check that acpi_wakeup_address is below 1MB v2 matthieu castet
2008-04-11 9:55 ` Zhao Yakui
2008-04-11 15:12 ` Rafael J. Wysocki [this message]
2008-04-11 18:04 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804111712.24233.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=castet.matthieu@free.fr \
--cc=linux-acpi@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox