Re: [PATCH 08/13] ACPI: thinkpad-acpi: add sysfs led class support for thinklight (v3.1)

[Randy Dunlap <randy.dunlap@oracle.com>]

On Thu, 10 Apr 2008 00:53:00 -0300 Henrique de Moraes Holschuh wrote:

> Add a sysfs led class interface to the thinklight (light subdriver).
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
>  Documentation/laptops/thinkpad-acpi.txt |   25 +++++++++++---
>  drivers/misc/thinkpad_acpi.c            |   57 ++++++++++++++++++++++++++++++-
>  2 files changed, 76 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/laptops/thinkpad-acpi.txt b/Documentation/laptops/thinkpad-acpi.txt
> index 0f403ff..22c1ac4 100644
> --- a/Documentation/laptops/thinkpad-acpi.txt
> +++ b/Documentation/laptops/thinkpad-acpi.txt
> @@ -692,16 +692,31 @@ while others are still having problems. For more information:
>  
>  https://bugs.freedesktop.org/show_bug.cgi?id=2000
>  
> -ThinkLight control -- /proc/acpi/ibm/light
> -------------------------------------------
> +ThinkLight control
> +------------------
> +
> +procfs: /proc/acpi/ibm/light
> +sysfs attributes: as per led class, for the "tpacpi::thinklight" led
> +

Well, I would really prefer that we call LEDs "LED" instead of "led"
in user documentation.

> +procfs notes:
>  
> -The current status of the ThinkLight can be found in this file. A few
> -models which do not make the status available will show it as
> -"unknown". The available commands are:
> +The ThinkLight status can be read and set through the procfs interface.  A
> +few models which do not make the status available will show the ThinkLight
> +status as "unknown". The available commands are:
>  
>  	echo on  > /proc/acpi/ibm/light
>  	echo off > /proc/acpi/ibm/light
>  
> +sysfs notes:
> +
> +The ThinkLight sysfs interface is documented by the led class
> +documentation, in Documentation/leds-class.txt.  The ThinkLight led name
> +is "tpacpi::thinklight".
> +
> +Due to limitations in the sysfs led class, if the status of the thinklight
> +cannot be read or if it is unknown, thinkpad-acpi will report it as "off".
> +It is impossible to know if the status returned through sysfs is valid.
> +
>  Docking / undocking -- /proc/acpi/ibm/dock
>  ------------------------------------------


---
~Randy