From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Corentin CHARY <corentincj@iksaif.net>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Mattia Dongili <malattia@linux.it>
Subject: Re: [PATCH 4/7] ACPI: Introduce acpi_get_physical_pci_device
Date: Wed, 16 Apr 2008 20:14:54 +0100 [thread overview]
Message-ID: <20080416191453.GA27128@srcf.ucam.org> (raw)
In-Reply-To: <1208372398.1784.348.camel@queen.suse.de>
On Wed, Apr 16, 2008 at 08:59:58PM +0200, Thomas Renninger wrote:
> ACPI: Introduce acpi_get_physical_pci_device
>
> This is the same as acpi_get_physical_pci_device, but checks whether
> the ACPI device's HID has a valid PCI value. This one should get
> enhanced (later or if accepted), so that the returned struct *device
> PCI device is further evaluated if it's a PCI bridge and the device
> behind that bridge should be returned then.
> Sanity checks were taken over from Matthew Garrett.
The comment isn't quite right. It checks whether the ADR is a likely PCI
value, not a valid one.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2008-04-16 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 18:59 [PATCH 4/7] ACPI: Introduce acpi_get_physical_pci_device Thomas Renninger
2008-04-16 19:14 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416191453.GA27128@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=carlos@strangeworlds.co.uk \
--cc=corentincj@iksaif.net \
--cc=hmh@hmh.eng.br \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=malattia@linux.it \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox