Re: [PATCH 7/7] Who controls brightness functionality: vendor specific or generic video driver

Thomas Renninger
2008-04-17T19:32:20Z

On Wed, 2008-04-16 at 18:01 -0300, Henrique de Moraes Holschuh wrote:
> On Wed, 16 Apr 2008, Thomas Renninger wrote:
> > Index: linux-acpi-2.6_video_native_vs_vendor/drivers/misc/thinkpad_acpi.c
> > ===================================================================
> > --- linux-acpi-2.6_video_native_vs_vendor.orig/drivers/misc/thinkpad_acpi.c
> > +++ linux-acpi-2.6_video_native_vs_vendor/drivers/misc/thinkpad_acpi.c
> > @@ -4381,6 +4381,13 @@ static int __init brightness_init(struct
> > "module parameter\n");
> > return 1;
> > } else if (brightness_enable > 1) {
> > + if ((acpi_video_support & ACPI_VIDEO_BRIGHTNESS) &&
> > + !(acpi_video_support & ACPI_VIDEO_FORCE_VENDOR_SPECIFIC)) {
> > + printk(TPACPI_INFO "Brightness ignored, must be "
> > + "controlled by ACPI video driver\n");
> > + return 1;
> > + }
> > + /* Above, generic approach should make this check obsolete */
> > if (brightness_check_std_acpi_support()) {
> > printk(TPACPI_NOTICE
> > "standard ACPI backlight interface "
>
> Ack. But I am sure I will have to change this hunk a bit on
> thinkpad-acpi 0.20. This is not a big issue, and if you prefer, I can
> handle adding the above support for thinkpad-acpi 0.20 since it is
> likely going to be merged late due to its dependency on some stuff for
> the LED class that needs to be in mainline first...

I need to post another version, I hope to find some time over the
week-end.
I also need to go through and disable output switching also where
supported.

Thanks,

Thomas