[2.6.25-stable PATCH] regression: powertop says 120K wakeups/sec

[2.6.25-stable PATCH] regression: powertop says 120K wakeups/sec

[Len Brown]

From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Date:   Wed Apr 9 21:31:46 2008 -0400

commit 0fda6b403f0eca66ad8a7c946b3996e359100443
    
Patch to fix huge number of wakeups reported due to recent changes in
processor_idle.c. The problem was that the entry_method determination was
broken due to one of the recent commits (bc71bec91f987) causing
C1 entry to not to go to halt.
    
http://lkml.org/lkml/2008/3/22/124
    
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 788da97..836362b 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -848,6 +848,7 @@ static int acpi_processor_get_power_info_default(struct acpi_processor *pr)
 		/* all processors need to support C1 */
 		pr->power.states[ACPI_STATE_C1].type = ACPI_STATE_C1;
 		pr->power.states[ACPI_STATE_C1].valid = 1;
+		pr->power.states[ACPI_STATE_C1].entry_method = ACPI_CSTATE_HALT;
 	}
 	/* the C0 state only exists as a filler in our array */
 	pr->power.states[ACPI_STATE_C0].valid = 1;
@@ -960,6 +961,9 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)
 				 cx.address);
 		}
 
+		if (cx.type == ACPI_STATE_C1) {
+			cx.valid = 1;
+		}
 
 		obj = &(element->package.elements[2]);
 		if (obj->type != ACPI_TYPE_INTEGER)

Re: [stable] [2.6.25-stable PATCH] regression: powertop says 120K wakeups/sec

[Greg KH]

On Thu, Apr 24, 2008 at 08:15:19PM -0400, Len Brown wrote:
> From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> Date:   Wed Apr 9 21:31:46 2008 -0400
> 
> commit 0fda6b403f0eca66ad8a7c946b3996e359100443

I don't see this commit in Linus's tree, is it not needed in it and only
in the 2.6.25-stable tree as it was fixed some other way?

confused,

greg k-h