Re: [patch 21/54] PNP: add debug when assigning PNP resources

Bjorn Helgaas
2008-04-28T15:25:56Z

On Saturday 26 April 2008 03:26:20 pm Rene Herman wrote:
> On 25-04-08 20:38, Bjorn Helgaas wrote:
> > +#else
> > +void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc)
> > +{
> > +}
> > +#endif
>
> Not too important, but #ifdef could be inside body.

Much nicer, thanks.

I'll add your updates and acks and repost this series today.

> > + dev_dbg(&dev->dev, " io %d already set to 0x%llx-0x%llx "
> > + "flags 0x%x\n", idx, (unsigned long long) *start,
> > + (unsigned long long) *end, (int) *flags);
>
> I wanted to ask/comment why you're casting the flags to int though. It's an
> unsigned long, both in the resource and by type here. Ie, 0x%lx and no
> casting? (I btw also like %#lx better then the explicit 0x, but that doesn't
> really matter).

Two more good ideas. The cast was just me not paying attention, and
the "0x%x" habit is deeply ingrained. I'll change both.

Bjorn