public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Adam Belay <ambx1@neo.rr.com>, Adam M Belay <abelay@mit.edu>,
	Li Shaohua <shaohua.li@intel.com>,
	Matthieu Castet <castet.matthieu@free.fr>,
	Thomas Renninger <trenn@suse.de>,
	Rene Herman <rene.herman@keyaccess.nl>,
	Jaroslav Kysela <perex@perex.cz>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [patch 44/55] PNP: add pnp_get_pnp_resource()
Date: Mon, 28 Apr 2008 16:34:31 -0600	[thread overview]
Message-ID: <20080428223625.529988852@ldl.fc.hp.com> (raw)
In-Reply-To: 20080428223347.233593713@ldl.fc.hp.com

[-- Attachment #1: pnp-add-get-pnp-resource --]
[-- Type: text/plain, Size: 2376 bytes --]

In some places, we need to get the struct pnp_resource, not just
the struct resource, because ISAPNP needs to store the register
index in the pnp_resource.

I don't like pnp_get_pnp_resource() and hope that it is temporary,
but we need it for a little while.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

---
 drivers/pnp/base.h     |    3 +++
 drivers/pnp/resource.c |   24 ++++++++++++++++++------
 2 files changed, 21 insertions(+), 6 deletions(-)

Index: work10/drivers/pnp/base.h
===================================================================
--- work10.orig/drivers/pnp/base.h	2008-04-28 16:09:43.000000000 -0600
+++ work10/drivers/pnp/base.h	2008-04-28 16:09:43.000000000 -0600
@@ -21,6 +21,9 @@
 
 void pnp_init_resource(struct resource *res);
 
+struct pnp_resource *pnp_get_pnp_resource(struct pnp_dev *dev,
+					  unsigned int type, unsigned int num);
+
 #define PNP_MAX_PORT		40
 #define PNP_MAX_MEM		24
 #define PNP_MAX_IRQ		 2
Index: work10/drivers/pnp/resource.c
===================================================================
--- work10.orig/drivers/pnp/resource.c	2008-04-28 16:09:43.000000000 -0600
+++ work10/drivers/pnp/resource.c	2008-04-28 16:09:43.000000000 -0600
@@ -499,8 +499,8 @@
 #endif
 }
 
-struct resource *pnp_get_resource(struct pnp_dev *dev,
-				  unsigned int type, unsigned int num)
+struct pnp_resource *pnp_get_pnp_resource(struct pnp_dev *dev,
+					  unsigned int type, unsigned int num)
 {
 	struct pnp_resource_table *res = dev->res;
 
@@ -508,22 +508,34 @@
 	case IORESOURCE_IO:
 		if (num >= PNP_MAX_PORT)
 			return NULL;
-		return &res->port[num].res;
+		return &res->port[num];
 	case IORESOURCE_MEM:
 		if (num >= PNP_MAX_MEM)
 			return NULL;
-		return &res->mem[num].res;
+		return &res->mem[num];
 	case IORESOURCE_IRQ:
 		if (num >= PNP_MAX_IRQ)
 			return NULL;
-		return &res->irq[num].res;
+		return &res->irq[num];
 	case IORESOURCE_DMA:
 		if (num >= PNP_MAX_DMA)
 			return NULL;
-		return &res->dma[num].res;
+		return &res->dma[num];
 	}
 	return NULL;
 }
+
+struct resource *pnp_get_resource(struct pnp_dev *dev,
+				  unsigned int type, unsigned int num)
+{
+	struct pnp_resource *pnp_res;
+
+	pnp_res = pnp_get_pnp_resource(dev, type, num);
+	if (pnp_res)
+		return &pnp_res->res;
+
+	return NULL;
+}
 EXPORT_SYMBOL(pnp_get_resource);
 
 /* format is: pnp_reserve_irq=irq1[,irq2] .... */

-- 

  parent reply	other threads:[~2008-04-28 22:37 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 22:33 [patch 00/55] PNP cleanup, v5 Bjorn Helgaas
2008-04-28 22:33 ` [patch 01/55] PNP: turn on -DDEBUG when CONFIG_PNP_DEBUG is set Bjorn Helgaas
2008-04-28 22:33 ` [patch 02/55] ISAPNP: move config register addresses out of isapnp.h Bjorn Helgaas
2008-04-28 22:33 ` [patch 03/55] PNPACPI: continue after _CRS and _PRS errors Bjorn Helgaas
2008-04-28 22:33 ` [patch 04/55] PNP: make pnp_add_id() internal to PNP core Bjorn Helgaas
2008-04-28 22:33 ` [patch 05/55] PNP: change pnp_add_id() to allocate its own pnp_id structures Bjorn Helgaas
2008-04-28 22:33 ` [patch 06/55] PNP: add pnp_eisa_id_to_string() Bjorn Helgaas
2008-04-28 22:33 ` [patch 07/55] PNP: add pnp_alloc_dev() Bjorn Helgaas
2008-04-28 22:33 ` [patch 08/55] PNP: make pnp_add_card_id() internal to PNP core Bjorn Helgaas
2008-04-28 22:33 ` [patch 09/55] PNP: change pnp_add_card_id() to allocate its own pnp_id structures Bjorn Helgaas
2008-04-28 22:33 ` [patch 10/55] ISAPNP: pull pnp_add_card_id() out of isapnp_parse_card_id() Bjorn Helgaas
2008-04-28 22:33 ` [patch 11/55] PNP: add pnp_alloc_card() Bjorn Helgaas
2008-04-28 22:33 ` [patch 12/55] PNPACPI: pnpacpi_encode_ext_irq() wrongly set "irq" instead of "extended_irq" Bjorn Helgaas
2008-04-28 22:34 ` [patch 13/55] PNPACPI: use temporaries to reduce repetition Bjorn Helgaas
2008-04-28 22:34 ` [patch 14/55] PNPACPI: hoist dma_flags() out of pnpacpi_parse_allocated_dmaresource() Bjorn Helgaas
2008-04-28 22:34 ` [patch 15/55] PNPACPI: extend irq_flags() to set IORESOURCE_IRQ_SHAREABLE when appropriate Bjorn Helgaas
2008-04-28 22:34 ` [patch 16/55] PNPACPI: pass pnp_dev instead of acpi_handle Bjorn Helgaas
2008-04-28 22:34 ` [patch 17/55] PNP: add debug output to option registration Bjorn Helgaas
2008-04-28 22:34 ` [patch 18/55] PNP: remove pnp_resource_table from internal get/set interfaces Bjorn Helgaas
2008-04-28 22:34 ` [patch 19/55] PNP: remove more pnp_resource_table arguments Bjorn Helgaas
2008-04-28 22:34 ` [patch 20/55] PNP: add debug output to encoders Bjorn Helgaas
2008-04-28 22:34 ` [patch 21/55] PNP: add debug when assigning PNP resources Bjorn Helgaas
2008-04-28 22:34 ` [patch 22/55] PNP: add pnp_init_resources(struct pnp_dev *) interface Bjorn Helgaas
2008-04-28 22:34 ` [patch 23/55] PNP: remove pnp_resource_table from internal pnp_clean_resource_table interface Bjorn Helgaas
2008-04-28 22:34 ` [patch 24/55] PNP: remove unused interfaces using pnp_resource_table Bjorn Helgaas
2008-04-28 22:34 ` [patch 25/55] PNP: use dev_printk when possible Bjorn Helgaas
2008-04-28 22:34 ` [patch 26/55] PNP: factor pnp_init_resource_table() and pnp_clean_resource_table() Bjorn Helgaas
2008-04-28 22:34 ` [patch 27/55] PNP: add pnp_get_resource() interface Bjorn Helgaas
2008-04-28 22:34 ` [patch 28/55] PNP: remove pnp_mem_flags() as an lvalue Bjorn Helgaas
2008-04-28 22:34 ` [patch 29/55] PNP: convert resource accessors to use pnp_get_resource(), not pnp_resource_table Bjorn Helgaas
2008-04-28 22:34 ` [patch 30/55] PNP: use conventional "i" for loop indices Bjorn Helgaas
2008-04-28 22:34 ` [patch 31/55] PNP: reduce redundancy in pnp_assign_port() and others Bjorn Helgaas
2008-04-28 22:34 ` [patch 32/55] PNP: reduce redundancy in pnp_check_port() " Bjorn Helgaas
2008-04-28 22:34 ` [patch 33/55] PNP: reduce redundancy in pnp_set_current_resources() Bjorn Helgaas
2008-04-28 22:34 ` [patch 34/55] PNP: check for conflicts with all resources, not just earlier ones Bjorn Helgaas
2008-04-28 22:34 ` [patch 35/55] PNP: pass resources, not indexes, to pnp_check_port(), et al Bjorn Helgaas
2008-04-28 22:34 ` [patch 36/55] PNP: convert resource checks to use pnp_get_resource(), not pnp_resource_table Bjorn Helgaas
2008-04-28 22:34 ` [patch 37/55] PNP: convert encoders " Bjorn Helgaas
2008-04-28 22:34 ` [patch 38/55] PNP: convert assign, interface " Bjorn Helgaas
2008-04-28 22:34 ` [patch 39/55] PNP: remove PNP_MAX_* uses Bjorn Helgaas
2008-04-28 22:34 ` [patch 40/55] rtc: dont reference pnp_resource_table directly Bjorn Helgaas
2008-04-28 22:34 ` [patch 41/55] PNP: make pnp_resource_table private to PNP core Bjorn Helgaas
2008-04-28 22:34 ` [patch 42/55] PNP: remove pnp_resource_table references from resource decoders Bjorn Helgaas
2008-04-28 22:34 ` [patch 43/55] PNP: add struct pnp_resource Bjorn Helgaas
2008-04-28 22:34 ` Bjorn Helgaas [this message]
2008-04-28 22:34 ` [patch 45/55] PNP: add pnp_resource index for ISAPNP Bjorn Helgaas
2008-04-28 22:34 ` [patch 46/55] PNP: add pnp_new_resource() to find a new unset pnp_resource Bjorn Helgaas
2008-04-28 22:34 ` [patch 47/55] PNP: make generic pnp_add_irq_resource() Bjorn Helgaas
2008-04-28 22:34 ` [patch 48/55] PNP: make generic pnp_add_dma_resource() Bjorn Helgaas
2008-04-28 22:34 ` [patch 49/55] PNP: make generic pnp_add_io_resource() Bjorn Helgaas
2008-04-28 22:34 ` [patch 50/55] PNP: make generic pnp_add_mem_resource() Bjorn Helgaas
2008-04-28 22:34 ` [patch 51/55] ISAPNP: fold isapnp_read_resources() back into isapnp_get_resources() Bjorn Helgaas
2008-04-28 22:34 ` [patch 52/55] PNPACPI: move _CRS/_PRS warnings closer to the action Bjorn Helgaas
2008-04-28 22:34 ` [patch 53/55] PNP: make interfaces private to the PNP core Bjorn Helgaas
2008-04-28 22:34 ` [patch 54/55] ISAPNP: remove unused pnp_dev->regs field Bjorn Helgaas
2008-04-28 22:34 ` [patch 55/55] PNPBIOS: remove include/linux/pnpbios.h Bjorn Helgaas
2008-04-29  8:38 ` [patch 00/55] PNP cleanup, v5 Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428223625.529988852@ldl.fc.hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=abelay@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=ambx1@neo.rr.com \
    --cc=castet.matthieu@free.fr \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rene.herman@keyaccess.nl \
    --cc=shaohua.li@intel.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox