public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Holger Macht <hmacht@suse.de>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kristen.c.accardi@intel.com
Subject: [PATCH] bay: Exit if notify handler cannot be installed
Date: Mon, 5 May 2008 22:25:08 +0200	[thread overview]
Message-ID: <20080505202508.GA3690@homac> (raw)

If acpi_install_notify_handler() for a bay device fails, the bay driver is
superfluous. Most likely, another driver (like libata) is already caring
about this device anyway. Furthermore,
register_hotplug_dock_device(acpi_handle) from the dock driver must not be
called twice with the same handler. So clean up and exit.

Signed-off-by: Holger Macht <hmacht@suse.de>
---

diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
index d2fc941..ce9038f 100644
--- a/drivers/acpi/bay.c
+++ b/drivers/acpi/bay.c
@@ -311,6 +311,7 @@ static int bay_add(acpi_handle handle, int id)
 			bay_notify, new_bay);
 	if (ACPI_FAILURE(status)) {
 		printk(KERN_ERR PREFIX "Error installing bay notify handler\n");
+		goto bay_add_err;
 	}
 
 	/* if we are on a dock station, we should register for dock


             reply	other threads:[~2008-05-05 20:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 20:25 Holger Macht [this message]
2008-05-06  9:15 ` [PATCH] bay: Exit if notify handler cannot be installed Holger Macht
2008-05-06  9:23   ` Shaohua Li
2008-05-06  9:33     ` Holger Macht
2008-05-06  9:35       ` Holger Macht
2008-05-06 15:24         ` Henrique de Moraes Holschuh
2008-05-06 17:12           ` Holger Macht
2008-05-07  1:03         ` Shaohua Li
2008-05-06 15:18     ` Henrique de Moraes Holschuh
2008-05-06 15:20       ` Alan Cox
2008-05-06 15:39         ` Henrique de Moraes Holschuh
2008-05-06 15:49           ` Alan Cox
2008-05-06 17:17           ` Holger Macht
2008-05-06 17:13       ` Holger Macht
2008-05-07  1:04       ` Shaohua Li
2008-05-07  1:13         ` Henrique de Moraes Holschuh
2008-05-07  1:27           ` Shaohua Li
2008-05-07 12:37             ` Henrique de Moraes Holschuh
2008-05-07 12:43               ` Henrique de Moraes Holschuh
2008-05-07 13:05               ` Holger Macht
2008-05-07 14:17               ` Matthew Garrett
  -- strict thread matches above, loose matches on Subject: below --
2008-05-21 10:45 Holger Macht
2008-05-21 10:59 ` Matthew Garrett
2008-05-21 11:06   ` Holger Macht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080505202508.GA3690@homac \
    --to=hmacht@suse.de \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox