From: Holger Macht <hmacht@suse.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Accardi, Kristen C" <kristen.c.accardi@intel.com>
Subject: Re: [PATCH] bay: Exit if notify handler cannot be installed
Date: Tue, 6 May 2008 11:33:16 +0200 [thread overview]
Message-ID: <20080506093315.GD4378@homac> (raw)
In-Reply-To: <1210065811.12668.1.camel@sli10-desk.sh.intel.com>
On Di 06. Mai - 17:23:31, Shaohua Li wrote:
> On Tue, 2008-05-06 at 17:15 +0800, Holger Macht wrote:
> > On Mo 05. Mai - 22:25:08, Holger Macht wrote:
> > > If acpi_install_notify_handler() for a bay device fails, the bay
> > driver is
> > > superfluous. Most likely, another driver (like libata) is already
> > caring
> > > about this device anyway. Furthermore,
> > > register_hotplug_dock_device(acpi_handle) from the dock driver must
> > not be
> > > called twice with the same handler. So clean up and exit.
> >
> > The patch needs some more work. I'll send an updated one as soon as
> > ready.
> The bay driver is duplicated with libata, I thought we should delete it.
> See bug http://bugzilla.kernel.org/show_bug.cgi?id=9526
Yes, I know, but couldn't it be helpful on systems not using libata?
Regards,
Holger
next prev parent reply other threads:[~2008-05-06 9:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 20:25 [PATCH] bay: Exit if notify handler cannot be installed Holger Macht
2008-05-06 9:15 ` Holger Macht
2008-05-06 9:23 ` Shaohua Li
2008-05-06 9:33 ` Holger Macht [this message]
2008-05-06 9:35 ` Holger Macht
2008-05-06 15:24 ` Henrique de Moraes Holschuh
2008-05-06 17:12 ` Holger Macht
2008-05-07 1:03 ` Shaohua Li
2008-05-06 15:18 ` Henrique de Moraes Holschuh
2008-05-06 15:20 ` Alan Cox
2008-05-06 15:39 ` Henrique de Moraes Holschuh
2008-05-06 15:49 ` Alan Cox
2008-05-06 17:17 ` Holger Macht
2008-05-06 17:13 ` Holger Macht
2008-05-07 1:04 ` Shaohua Li
2008-05-07 1:13 ` Henrique de Moraes Holschuh
2008-05-07 1:27 ` Shaohua Li
2008-05-07 12:37 ` Henrique de Moraes Holschuh
2008-05-07 12:43 ` Henrique de Moraes Holschuh
2008-05-07 13:05 ` Holger Macht
2008-05-07 14:17 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2008-05-21 10:45 Holger Macht
2008-05-21 10:59 ` Matthew Garrett
2008-05-21 11:06 ` Holger Macht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506093315.GD4378@homac \
--to=hmacht@suse.de \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox