From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Macht Subject: Re: [PATCH] bay: Exit if notify handler cannot be installed Date: Tue, 6 May 2008 11:33:16 +0200 Message-ID: <20080506093315.GD4378@homac> References: <20080505202508.GA3690@homac> <20080506091522.GA4378@homac> <1210065811.12668.1.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.suse.de ([195.135.220.2]:37661 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755618AbYEFJbI (ORCPT ); Tue, 6 May 2008 05:31:08 -0400 Content-Disposition: inline In-Reply-To: <1210065811.12668.1.camel@sli10-desk.sh.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Shaohua Li Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Accardi, Kristen C" On Di 06. Mai - 17:23:31, Shaohua Li wrote: > On Tue, 2008-05-06 at 17:15 +0800, Holger Macht wrote: > > On Mo 05. Mai - 22:25:08, Holger Macht wrote: > > > If acpi_install_notify_handler() for a bay device fails, the bay > > driver is > > > superfluous. Most likely, another driver (like libata) is already > > caring > > > about this device anyway. Furthermore, > > > register_hotplug_dock_device(acpi_handle) from the dock driver must > > not be > > > called twice with the same handler. So clean up and exit. > > > > The patch needs some more work. I'll send an updated one as soon as > > ready. > The bay driver is duplicated with libata, I thought we should delete it. > See bug http://bugzilla.kernel.org/show_bug.cgi?id=9526 Yes, I know, but couldn't it be helpful on systems not using libata? Regards, Holger