From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Pavel Machek <pavel@ucw.cz>,
pm list <linux-pm@lists.linux-foundation.org>,
Greg KH <greg@kroah.com>
Subject: [PATCH 2/2] PCI PM: Introduce pci_preferred_state
Date: Tue, 6 May 2008 23:49:17 +0200 [thread overview]
Message-ID: <200805062349.18683.rjw@sisk.pl> (raw)
In-Reply-To: <200805062342.42789.rjw@sisk.pl>
[Well, this essentially is a PCI patch, but it modifies include/linux/pm.h too.]
---
From: Rafael J. Wysocki <rjw@sisk.pl>
The new suspend and hibernation callbacks introduced with
'struct pm_ops' and 'struct pm_ext_ops' do not take a
pm_message_t argument, so the drivers using them will not be able
to use pci_choose_state() in its present form. For this reason,
introduce the new function pci_preferred_state() playing the role
of pci_choose_state(), but taking only a pointer to the device
object.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/pci/pci.c | 33 ++++++++++++++++++++++++++++++++-
include/linux/pci.h | 1 +
include/linux/pm.h | 10 ++++++++++
3 files changed, 43 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/pci/pci.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci.c
+++ linux-2.6/drivers/pci/pci.c
@@ -509,7 +509,38 @@ pci_set_power_state(struct pci_dev *dev,
}
pci_power_t (*platform_pci_choose_state)(struct pci_dev *dev);
-
+
+/**
+ * pci_preferred_state - Choose the preferred power state of a PCI device
+ * @dev: PCI device to be put into the low power state
+ * @sp: Information aboutabout what the driver would prefer to do with
+ * the device if there were no platform-implemeted policy.
+ *
+ * Returns PCI power state suitable for given device and given suspend policy.
+ * The policy, however, is only used if platform_pci_choose_state() fails or is
+ * not present. Otherwise, it is assumed that platform_pci_choose_state()
+ * implements the right policy.
+ */
+
+pci_power_t pci_preferred_state(struct pci_dev *dev, enum suspend_policy sp)
+{
+ pci_power_t ret;
+
+ if (!pci_find_capability(dev, PCI_CAP_ID_PM))
+ return PCI_D0;
+
+ ret = (sp == SP_TURN_OFF) ? PCI_D3hot : PCI_D0;
+ if (platform_pci_choose_state) {
+ pci_power_t platform_ret = platform_pci_choose_state(dev);
+
+ if (platform_ret != PCI_POWER_ERROR)
+ ret = platform_ret;
+ }
+ return ret;
+}
+
+EXPORT_SYMBOL(pci_preferred_state);
+
/**
* pci_choose_state - Choose the power state of a PCI device
* @dev: PCI device to be suspended
Index: linux-2.6/include/linux/pci.h
===================================================================
--- linux-2.6.orig/include/linux/pci.h
+++ linux-2.6/include/linux/pci.h
@@ -615,6 +615,7 @@ size_t pci_get_rom_size(void __iomem *ro
int pci_save_state(struct pci_dev *dev);
int pci_restore_state(struct pci_dev *dev);
int pci_set_power_state(struct pci_dev *dev, pci_power_t state);
+pci_power_t pci_preferred_state(struct pci_dev *dev, enum suspend_policy sp);
pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state);
int pci_enable_wake(struct pci_dev *dev, pci_power_t state, int enable);
Index: linux-2.6/include/linux/pm.h
===================================================================
--- linux-2.6.orig/include/linux/pm.h
+++ linux-2.6/include/linux/pm.h
@@ -391,6 +391,16 @@ struct dev_pm_info {
};
/*
+ * Used to pass the information about what the driver would prefer to do with
+ * its device before the system in put into a sleep state, if there were no
+ * platform-implemeted policy.
+ */
+enum suspend_policy {
+ SP_TURN_ON,
+ SP_TURN_OFF,
+};
+
+/*
* The PM_EVENT_ messages are also used by drivers implementing the legacy
* suspend framework, based on the ->suspend() and ->resume() callbacks common
* for suspend and hibernation transitions, according to the rules below.
next prev parent reply other threads:[~2008-05-06 21:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 21:42 [PATCH 0/2] Patches for 2.6.27, dependent on the other trees Rafael J. Wysocki
2008-05-06 21:44 ` [PATCH 1/2] ACPI PM: Add suspend sequence workaround Rafael J. Wysocki
2008-05-06 21:57 ` Carlos Corbacho
2008-05-06 22:09 ` Rafael J. Wysocki
2008-05-07 9:29 ` Pavel Machek
2008-05-07 12:21 ` Rafael J. Wysocki
2008-05-09 17:20 ` Rafael J. Wysocki
2008-05-09 17:21 ` [RFC][PATCH 1/2] ACPI PM: Remove obsolete Toshiba workaround Rafael J. Wysocki
2008-05-12 7:18 ` Pavel Machek
2008-05-09 17:23 ` [RFC][PATCH 2/2] ACPI PM: Add possibility to change suspend sequence Rafael J. Wysocki
2008-05-12 7:23 ` Pavel Machek
2008-05-12 22:34 ` Rafael J. Wysocki
2008-05-12 23:03 ` Rafael J. Wysocki
2008-05-19 22:36 ` Pavel Machek
2008-05-06 21:49 ` Rafael J. Wysocki [this message]
2008-05-07 9:33 ` [PATCH 2/2] PCI PM: Introduce pci_preferred_state Pavel Machek
2008-05-07 12:22 ` Rafael J. Wysocki
2008-05-07 15:45 ` [linux-pm] " Alan Stern
2008-05-07 18:32 ` Rafael J. Wysocki
2008-05-09 15:44 ` Rafael J. Wysocki
2008-05-09 16:47 ` Jesse Barnes
2008-05-09 17:13 ` [linux-pm] " Rafael J. Wysocki
2008-05-09 17:24 ` Jesse Barnes
2008-05-09 17:34 ` [linux-pm] " Rafael J. Wysocki
2008-05-09 17:37 ` Jesse Barnes
2008-05-09 21:44 ` Rafael J. Wysocki
2008-05-09 22:13 ` Jesse Barnes
2008-05-09 22:57 ` Rafael J. Wysocki
2008-05-10 18:28 ` Rafael J. Wysocki
2008-05-12 14:00 ` Pavel Machek
2008-05-12 14:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805062349.18683.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox