From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Johannes Berg <johannes@sipsolutions.net>,
Shaohua Li <shaohua.li@intel.com>,
David Brownell <david-b@pacbell.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/4] ACPI Hibernation: Use ACPI hardware signature
Date: Wed, 7 May 2008 23:04:38 +0200 [thread overview]
Message-ID: <20080507210438.GD18516@elf.ucw.cz> (raw)
In-Reply-To: <200805071428.02613.rjw@sisk.pl>
Hi!
> > > +static int __init acpi_s4_nosigcheck(char *str)
> > > +{
> > > + nosigcheck = true;
> > > + return 1;
> > > +}
> > > +__setup("acpi_s4_nosigcheck", acpi_s4_nosigcheck);
> > > +
> >
> > Needs a patch to Documentation/ , too.
>
> Yes, thanks.
>
> > > + /* Check the hardware signature */
> > > + if (facs && s4_hardware_signature != facs->hardware_signature)
> >
> > do you need && !nosigcheck here ?
>
> No, facs is NULL if !nosigcheck.
Aha, ook. You can add my ACK when you add the Documentation/.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-05-07 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 21:31 [PATCH 0/4] Patches for 2.6.27 Rafael J. Wysocki
2008-05-06 21:33 ` [PATCH 1/4] ACPI Hibernation: Use ACPI hardware signature Rafael J. Wysocki
2008-05-07 9:20 ` Pavel Machek
2008-05-07 12:28 ` Rafael J. Wysocki
2008-05-07 21:04 ` Pavel Machek [this message]
2008-05-09 15:27 ` Rafael J. Wysocki
2008-05-06 21:35 ` [PATCH 2/4] APM emulation: Notify about all suspend events, not just APM invoked ones (v2) Rafael J. Wysocki
2008-05-07 9:22 ` Pavel Machek
2008-05-06 21:37 ` [PATCH 3/4] ACPI PM: acpi_pm_device_sleep_state() cleanup Rafael J. Wysocki
2008-05-06 21:38 ` [PATCH 4/4] PCI ACPI: Drop the second argument of platform_pci_choose_state Rafael J. Wysocki
2008-05-07 9:24 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507210438.GD18516@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=david-b@pacbell.net \
--cc=jbarnes@virtuousgeek.org \
--cc=johannes@sipsolutions.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox