From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Machek <pavel@suse.cz>
Subject: Re: [PATCH 1/4] ACPI Hibernation: Use ACPI hardware signature
Date: Wed, 7 May 2008 23:04:38 +0200
Message-ID: <20080507210438.GD18516@elf.ucw.cz>
References: <200805062331.39454.rjw@sisk.pl> <200805062333.17558.rjw@sisk.pl> <20080507092055.GA13858@elf.ucw.cz> <200805071428.02613.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:52786 "EHLO
	atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752635AbYEGVD5 (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Wed, 7 May 2008 17:03:57 -0400
Content-Disposition: inline
In-Reply-To: <200805071428.02613.rjw@sisk.pl>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, pm list <linux-pm@lists.linux-foundation.org>, Johannes Berg <johannes@sipsolutions.net>, Shaohua Li <shaohua.li@intel.com>, David Brownell <david-b@pacbell.net>, Jesse Barnes <jbarnes@virtuousgeek.org>

Hi!

> > > +static int __init acpi_s4_nosigcheck(char *str)
> > > +{
> > > +	nosigcheck = true;
> > > +	return 1;
> > > +}
> > > +__setup("acpi_s4_nosigcheck", acpi_s4_nosigcheck);
> > > +
> > 
> > Needs a patch to Documentation/ , too.
> 
> Yes, thanks.
> 
> > > +	/* Check the hardware signature */
> > > +	if (facs && s4_hardware_signature != facs->hardware_signature)
> > 
> > do you need && !nosigcheck here ?
> 
> No, facs is NULL if !nosigcheck.

Aha, ook. You can add my ACK when you add the Documentation/.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html