From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: cpufreq@lists.linux.org.uk,
"Alex Villacís Lasso" <avillaci@ceibo.fiec.espol.edu.ec>,
linux-acpi@vger.kernel.org
Subject: Re: About p4-clockmod breakage/removal
Date: Wed, 14 May 2008 10:15:03 +0100 [thread overview]
Message-ID: <20080514091503.GA28678@srcf.ucam.org> (raw)
In-Reply-To: <200805132335.33118.lenb@kernel.org>
On Tue, May 13, 2008 at 11:35:32PM -0400, Len Brown wrote:
> cpufreq is not designed to manage thermals, and putting p4_clockmod
> underneath it to manage thermals is a mistake.
Check processor_thermal.c. It explicitly interfaces with cpufreq in
order to perform P state management.
> There is already a well known thermal throttling interface
> available via ACPI and it does not need p4_clockmod to run.
> Passive trip points work automatically even without cpufreq being present.
> If they do not, then we need to fix them.
You're assuming that the throttling interface is always exposed via
ACPI. I've seen machines where this isn't the case.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-05-14 9:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48246C3E.7010608@ceibo.fiec.espol.edu.ec>
2008-05-14 0:48 ` About p4-clockmod breakage/removal Len Brown
2008-05-14 0:56 ` Matthew Garrett
2008-05-14 3:35 ` Len Brown
2008-05-14 9:15 ` Matthew Garrett [this message]
2008-05-14 15:18 ` Len Brown
2008-05-14 23:11 ` Matthew Garrett
2008-05-14 11:18 ` Pavel Troller
2008-05-14 17:22 ` Len Brown
2008-05-15 1:55 ` Henrique de Moraes Holschuh
2008-05-14 11:36 ` Thomas Renninger
2008-05-14 11:42 ` Matthew Garrett
2008-05-14 12:49 ` Thomas Renninger
2008-05-14 12:56 ` Matthew Garrett
2008-05-14 15:28 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514091503.GA28678@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=avillaci@ceibo.fiec.espol.edu.ec \
--cc=cpufreq@lists.linux.org.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox