Re: [RFC][PATCH 2/2] ACPI PM: Add possibility to change suspend sequence

[Pavel Machek <pavel@suse.cz>]

Hi!

> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> There are some systems out there that don't work correctly with
> our current suspend/hibernation code ordering.  Provide a workaround
> for these systems allowing them to pass the
> 'acpi_sleep=old_ordering' in the kernel command line which will make
> the kernel use the pre-ACPI 2.0 suspend code ordering.
> 
> Unfortunately, that requires us to rework the resuming of devices for
> recovering the platform in case one of the device drivers' .suspend()
> routines returns error code.  Namely, ACPI 1.0 specifies that _PTS
> should be called before suspending devices, but _WAK still should be
> called before resuming them in order to undo the changes made by
> _PTS.  However, if there is an error during suspending devices, they
> are automatically resumed without returning control to the PM core
> and that has to be changed.  For this reason, the high-level suspend
> and hibernation code has to be changed as well and new platform
> callbacks are necessary.
> 
> The patch also reorders and refactors the ACPI suspend/hibernation
> code to avoid duplication as far as reasonably possible.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

I like it. ACK.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html