public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Shaohua Li <shaohua.li@intel.com>
Subject: Re: [PATCH 1/7] ACPI Hibernation: Use ACPI hardware signature
Date: Tue, 20 May 2008 17:17:48 +0200	[thread overview]
Message-ID: <20080520151748.GA2067@elf.ucw.cz> (raw)
In-Reply-To: <200805200131.33913.rjw@sisk.pl>

Hi!

> From: Shaohua Li <shaohua.li@intel.com>
> 
> ACPI defines a hardware signature. BIOS calculates the signature
> according to hardware configure, if hardware changes, the signature
> will change, in this case, S4 resume should fail.
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> Acked-by: Pavel Machek <pavel@suse.cz>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

I guess I'm quite late to the party, but... could we make this use
acpi_sleep= command line option, and related variable?

That brings advantage of existing /proc/sys interface, so that s2disk
could do blacklist in userspace, and easily...

									Pavel

> @@ -152,6 +152,11 @@ and is between 256 and 4096 characters. 
>  			s3_beep is for debugging; it makes the PC's speaker beep
>  			as soon as the kernel's real-mode entry point is called.
>  
> +	acpi_s4_nosigcheck [HW,ACPI] S4 hardware signature
> +			ACPI will ignore the S4 hardware signature
> +			default: The hardware signature is checked during
> +			         resume from S4.
> +
>  	acpi_sci=	[HW,ACPI] ACPI System Control Interrupt trigger mode
>  			Format: { level | edge | high | low }
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-05-20 15:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19 23:29 [PATCH 0/7] Patches for 2.6.27 Rafael J. Wysocki
2008-05-19 23:31 ` [PATCH 1/7] ACPI Hibernation: Use ACPI hardware signature Rafael J. Wysocki
2008-05-20 15:17   ` Pavel Machek [this message]
2008-05-20 19:51     ` Rafael J. Wysocki
2008-05-21 21:16       ` [PATCH 1/7] ACPI Hibernation: Use ACPI hardware signature (rev. 2) Rafael J. Wysocki
2008-05-21 22:55         ` Pavel Machek
2008-05-19 23:33 ` [PATCH 2/7] APM emulation: Notify about all suspend events, not just APM invoked ones (v2) Rafael J. Wysocki
2008-05-19 23:34 ` [PATCH 3/7] ACPI PM: acpi_pm_device_sleep_state() cleanup Rafael J. Wysocki
2008-05-19 23:36 ` [PATCH 4/7] PCI ACPI: Drop the second argument of platform_pci_choose_state Rafael J. Wysocki
2008-05-19 23:38 ` [PATCH 5/7] ACPI PM: Remove obsolete Toshiba workaround Rafael J. Wysocki
2008-05-19 23:40 ` [PATCH 6/7] Freezer: Introduce PF_FREEZER_NOSIG Rafael J. Wysocki
2008-05-19 23:41 ` [PATCH 7/7] ACPI PM: Add possibility to change suspend sequence Rafael J. Wysocki
2008-05-20 15:20   ` Pavel Machek
2008-05-21 21:18     ` [PATCH 7/7] ACPI PM: Add possibility to change suspend sequence (rev. 2) Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080520151748.GA2067@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox