public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kristen.c.accardi@intel.com, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] bay: Exit if notify handler cannot be installed
Date: Wed, 21 May 2008 11:59:44 +0100	[thread overview]
Message-ID: <20080521105944.GA30728@srcf.ucam.org> (raw)
In-Reply-To: <20080521104547.GA8097@homac>

On Wed, May 21, 2008 at 12:45:47PM +0200, Holger Macht wrote:
> If acpi_install_notify_handler() for a bay device fails, the bay driver is
> superfluous. Most likely, another driver (like libata) is already caring
> about this device anyway. Furthermore,
> register_hotplug_dock_device(acpi_handle) from the dock driver must not be
> called twice with the same handler. This would result in an endless loop
> consuming 100% of CPU. So clean up and exit.

The bay driver still provides the only mechanism for calling the eject 
methods.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2008-05-21 11:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 10:45 [PATCH] bay: Exit if notify handler cannot be installed Holger Macht
2008-05-21 10:59 ` Matthew Garrett [this message]
2008-05-21 11:06   ` Holger Macht
  -- strict thread matches above, loose matches on Subject: below --
2008-05-05 20:25 Holger Macht
2008-05-06  9:15 ` Holger Macht
2008-05-06  9:23   ` Shaohua Li
2008-05-06  9:33     ` Holger Macht
2008-05-06  9:35       ` Holger Macht
2008-05-06 15:24         ` Henrique de Moraes Holschuh
2008-05-06 17:12           ` Holger Macht
2008-05-07  1:03         ` Shaohua Li
2008-05-06 15:18     ` Henrique de Moraes Holschuh
2008-05-06 15:20       ` Alan Cox
2008-05-06 15:39         ` Henrique de Moraes Holschuh
2008-05-06 15:49           ` Alan Cox
2008-05-06 17:17           ` Holger Macht
2008-05-06 17:13       ` Holger Macht
2008-05-07  1:04       ` Shaohua Li
2008-05-07  1:13         ` Henrique de Moraes Holschuh
2008-05-07  1:27           ` Shaohua Li
2008-05-07 12:37             ` Henrique de Moraes Holschuh
2008-05-07 12:43               ` Henrique de Moraes Holschuh
2008-05-07 13:05               ` Holger Macht
2008-05-07 14:17               ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521105944.GA30728@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox