From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 1/7] ACPI Hibernation: Use ACPI hardware signature (rev. 2) Date: Thu, 22 May 2008 00:55:01 +0200 Message-ID: <20080521225501.GA25208@elf.ucw.cz> References: <200805200129.19904.rjw@sisk.pl> <20080520151748.GA2067@elf.ucw.cz> <200805202151.11448.rjw@sisk.pl> <200805212316.01025.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:54030 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759241AbYEUWyM (ORCPT ); Wed, 21 May 2008 18:54:12 -0400 Content-Disposition: inline In-Reply-To: <200805212316.01025.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Len Brown , ACPI Devel Maling List , pm list , Shaohua Li Hi! > > > > ACPI defines a hardware signature. BIOS calculates the signature > > > > according to hardware configure, if hardware changes, the signature > > > > will change, in this case, S4 resume should fail. > > > > > > > > Signed-off-by: Shaohua Li > > > > Acked-by: Pavel Machek > > > > Signed-off-by: Rafael J. Wysocki > > > > > > I guess I'm quite late to the party, but... could we make this use > > > acpi_sleep= command line option, and related variable? > > > > > > That brings advantage of existing /proc/sys interface, so that s2disk > > > could do blacklist in userspace, and easily... > > > > If I have the time. > > Okay, patch reworked. > > Len, please disregard the previous version, the current one is > appended. Thanks a lot! Pavel > Signed-off-by: Shaohua Li > Signed-off-by: Rafael J. Wysocki ACK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html