public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* [patch -v2 17/23] acpi: use memory_read_from_buffer
       [not found] <20080601231329.223608711@gmail.com>
@ 2008-06-01 23:13 ` akinobu.mita
  0 siblings, 0 replies; only message in thread
From: akinobu.mita @ 2008-06-01 23:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: Len Brown, linux-acpi

[-- Attachment #1: acpi-use-memory-read-from-buffer.patch --]
[-- Type: text/plain, Size: 1245 bytes --]

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org
---
 drivers/acpi/system.c |   15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

Index: 2.6-git/drivers/acpi/system.c
===================================================================
--- 2.6-git.orig/drivers/acpi/system.c
+++ 2.6-git/drivers/acpi/system.c
@@ -77,7 +77,6 @@ static ssize_t acpi_table_show(struct ko
 	    container_of(bin_attr, struct acpi_table_attr, attr);
 	struct acpi_table_header *table_header = NULL;
 	acpi_status status;
-	ssize_t ret_count = count;
 
 	status =
 	    acpi_get_table(table_attr->name, table_attr->instance,
@@ -85,18 +84,8 @@ static ssize_t acpi_table_show(struct ko
 	if (ACPI_FAILURE(status))
 		return -ENODEV;
 
-	if (offset >= table_header->length) {
-		ret_count = 0;
-		goto end;
-	}
-
-	if (offset + ret_count > table_header->length)
-		ret_count = table_header->length - offset;
-
-	memcpy(buf, ((char *)table_header) + offset, ret_count);
-
-      end:
-	return ret_count;
+	return memory_read_from_buffer(buf, count, &offset,
+					table_header, table_header->length);
 }
 
 static void acpi_table_attr_init(struct acpi_table_attr *table_attr,

-- 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-06-01 23:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20080601231329.223608711@gmail.com>
2008-06-01 23:13 ` [patch -v2 17/23] acpi: use memory_read_from_buffer akinobu.mita

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox