From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Justin Mattock <justinmattock@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: Re: ACPI: EC: GPE storm detected, disabling EC GPE
Date: Sat, 7 Jun 2008 13:59:04 +0300 [thread overview]
Message-ID: <200806071359.04426.maximlevitsky@gmail.com> (raw)
In-Reply-To: <20080606235526.783acc83.akpm@linux-foundation.org>
On Saturday, 7 June 2008 09:55:26 Andrew Morton wrote:
> On Sat, 7 Jun 2008 06:21:54 +0000 "Justin Mattock" <justinmattock@gmail.com> wrote:
>
> > Well; I was hoping it was going to be just an easy fix, but unfortunately
> > changing
> > if (atomic_read(&ec->irq_count) > 5) {
> > to
> > if (atomic_read(&ec->irq_count) > 20) {
> > does seem to make the message disappear, for a while, probably at
> > around three hours,(for me at least) then the message appeared again.
> > :-(
> > So leaving me back to the beginning of try to have a go at this.
> > regards;
>
> I removed bugzilla from cc - that only works if there's [Bug 1234] in
> the Subject:.
>
> I added linux-acpi to cc - this is an acpi problem.
>
> What Justin is mysteriously referring to here is:
>
>
> : From: "Justin Mattock" <justinmattock@gmail.com>
> : To: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
> : Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> : Subject: GPE storm detected, disabling EC GPE
> : Date: Thu, 5 Jun 2008 21:01:55 +0000
> : Sender: linux-kernel-owner@vger.kernel.org
> :
> : FWIW I noticed a post where the person had changed 5 to 20, and it
> : seemed to work for them;
> : So with that in mind I decide to give that a go, here is the location:
> : drivers/acpi/ec.c
> : @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
> : {
> : acpi_status status = AE_OK;
> : struct acpi_ec *ec = data;
> : u8 state = acpi_ec_read_status(ec);
> :
> : pr_debug(PREFIX "~~~> interrupt\n");
> : atomic_inc(&ec->irq_count);
> : - if (atomic_read(&ec->irq_count) > 5) {
> : + if (atomic_read(&ec->irq_count) > 20) {
> : pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
> : ec_switch_to_poll_mode(ec);
> : goto end;
> : }
> :
> : Now I don't know if this will work for other brands, but for
> : me(Macbook Pro ATI chipset) I have not received the
> : GPE storm detected, disabling EC GPE message, but it's only been an
> : hour, maybe after two or three this might appear.
> : Also is this good or bad to set 5 to 20 for the system?
>
> Could someone from acpi land please help here?
>
> Justin, has this machine always had this problem or is it something
> which earlier kernels handled correctly?
>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
I have acer aspire 5720G which shows this message in latest -git
but doesn't show it in ubuntu 2.6.24 kernel.
I also noticed that in -git volume wheel behaves strangely, it sometimes increases volume
when I rotate it in direction of decrease, and vise versa.
Since the EC is in charge of volume wheel, it could be related.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2008-06-07 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dd18b0c30806062321x2918f6feq7c817bde52ba0c4c@mail.gmail.com>
2008-06-07 6:55 ` ACPI: EC: GPE storm detected, disabling EC GPE Andrew Morton
2008-06-07 10:59 ` Maxim Levitsky [this message]
2008-06-07 14:31 ` Guillaume Chazarain
2008-06-07 15:47 ` Justin Mattock
2008-06-07 19:28 ` Alexey Starikovskiy
2008-06-07 20:35 ` Justin Mattock
2008-06-07 21:27 ` Alexey Starikovskiy
2008-06-07 23:20 ` Justin Mattock
2008-06-08 14:21 ` Pavel Machek
2008-06-11 10:29 ` Alexey Starikovskiy
2008-06-11 18:39 ` Justin Mattock
2008-06-10 15:30 ` Len Brown
2008-06-10 18:37 ` Justin Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806071359.04426.maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=astarikovskiy@suse.de \
--cc=justinmattock@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox