public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-acpi@vger.kernel.org, ibm-acpi@hmh.eng.br
Subject: Re: [RFC] Allow notifications on method execution
Date: Fri, 20 Jun 2008 19:33:44 -0300	[thread overview]
Message-ID: <20080620223344.GC3417@khazad-dum.debian.net> (raw)
In-Reply-To: <20080620221308.GB18980@srcf.ucam.org>

On Fri, 20 Jun 2008, Matthew Garrett wrote:
> On Fri, Jun 20, 2008 at 07:01:20PM -0300, Henrique de Moraes Holschuh wrote:
> > Sounds like a good idea, but in order to do that, we just need to let
> > kernel drivers hook to GPE handlers somehow.  I'd be quite happy to add
> > support for it to thinkpad-acpi.
> 
> I expected that the method name would probably be more consistent, 
> whereas the GPE number might change in a way that was difficult to hook. 
> There's only three CMOS update methods in the range of Thinkpad BIOSes, 
> IIRC?

True.  Well, both would work, and I'd have to add this as a whitelist
anyway (which is NOT a problem, as we are talking about old thinkpads
anyway, and there is a finite, non-extremely-huge number of those).

It works marginally better if one traps the GPE, as that looks a lot
more like what one gets in a modern thinkpad instead of what one gets
from the NVRAM (look at the nvram polling code in thinkpad-acpi to
understand what I mean.  Some not so pretty crap was required in there
due to deal with loss of information in the VOLUME/MUTE handling...)

Hotfixing the AML would also allow one to do all of this and more (maybe
hell will freeze over and Len will let us do it :-) ).

Anyway, if we add notifications for normal nodes, please add them for
GPEs too.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2008-06-20 22:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20 15:22 [RFC] Allow notifications on method execution Matthew Garrett
2008-06-20 19:39 ` Henrique de Moraes Holschuh
2008-06-20 19:58   ` Matthew Garrett
2008-06-20 22:01     ` Henrique de Moraes Holschuh
2008-06-20 22:13       ` Matthew Garrett
2008-06-20 22:33         ` Henrique de Moraes Holschuh [this message]
2008-06-20 22:37           ` Matthew Garrett
2008-06-23  6:56 ` Zhao Yakui
2008-06-23 13:09   ` Henrique de Moraes Holschuh
2008-06-23 13:18     ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080620223344.GC3417@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox