Linux ACPI
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Ingo Molnar <mingo@elte.hu>, Pavel Machek <pavel@suse.cz>,
	Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] x86 ACPI: normalize segment descriptor register on resume
Date: Thu, 26 Jun 2008 01:17:16 -0700	[thread overview]
Message-ID: <20080626011716.e8c412dd.akpm@linux-foundation.org> (raw)
In-Reply-To: <200806252217.27059.rjw@sisk.pl>

On Wed, 25 Jun 2008 22:17:26 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Wednesday, 25 of June 2008, Ingo Molnar wrote:
> > 
> > * Pavel Machek <pavel@suse.cz> wrote:
> > 
> > > Acked-by: Pavel Machek <pavel@suse.cz>
> > > 
> > > If this could be sneaked into Ingo's tree for some automated testing, 
> > > that would be good.
> > 
> > sure - i have applied it to tip/out-of-tree. I'm equally nervous about 
> > this change - it affects every suspend+resume cycle that people do on 
> > those boxes which are working just fine currently.
> > 
> > btw., it would get a lot more coverage on my test-systems if this commit 
> > in tip/out-of-tree:
> > 
> > | commit 01259383c345d13b70efcc549439927ae64dc66d
> > | Author: David Brownell <david-b@pacbell.net>
> > | Date:   Fri May 16 10:12:36 2008 +0200
> > |
> > |     sleepy linux self-test
> > 
> > was upstream and if it was enabled more prominently, instead of hidden 
> > behind the rather obscure condition of:
> > 
> >   config PM_TEST_SUSPEND
> >         bool "Test suspend/resume and wakealarm during bootup"
> >         depends on SUSPEND && PM_DEBUG && RTC_LIB=y
> > 
> > and even then it needs certain other config options related to RTC_LIB 
> > to actually work during bootup.
> > 
> > As a result of all this obstruction, the automated testing i do, which 
> > builds and boots more than 1 random kernel per minute, will only run 
> > this self-test once every hour or so.
> > 
> > I dont mind if this option breaks boxes (that its purpose: it does the 
> > same thing that a real suspend+resume does and suspend+resume frequently 
> > breaks boxes), but right now it's all obscured so heavily which makes 
> > automated testing a lot harder than it should be.
> > 
> > it would be wonderful if this excellent suspend+resume self-test was 
> > upstream and was more prominent! :-)
> 
> I thought it was in linux-next, wasn't it?
> 

Len seems to think that Rafael seems to think that Ingo seems to think
that this patch broke one of his boxes.

Is it so?

Thanks.

  reply	other threads:[~2008-06-26  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 21:03 [PATCH] x86 ACPI: normalize segment descriptor register on resume Rafael J. Wysocki
2008-06-24 21:46 ` Pavel Machek
2008-06-25 17:01   ` Ingo Molnar
2008-06-25 20:17     ` Rafael J. Wysocki
2008-06-26  8:17       ` Andrew Morton [this message]
2008-06-26  8:29         ` Ingo Molnar
2008-06-26  8:39           ` Rafael J. Wysocki
2008-06-26  8:51             ` Ingo Molnar
2008-06-26  8:56               ` Rafael J. Wysocki
2008-06-26  8:35         ` Rafael J. Wysocki
2008-06-24 21:47 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080626011716.e8c412dd.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox