linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	kernel-testers@vger.kernel.org,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [RFT] x86 acpi: normalize segment descriptor register on resume
Date: Tue, 1 Jul 2008 11:19:38 +0200	[thread overview]
Message-ID: <20080701091937.GA1871@elf.ucw.cz> (raw)
In-Reply-To: <4869D4A3.3020000@zytor.com>

Hi!

>>> The appended patch fixes a regression and is considered as 2.6.26 
>>> material. Everyone having a box with working suspend to RAM is gently 
>>> requested to test it and verify if it doesn't break things.
>>>
>>> The patch applies to the current -git.
>>
>> it's been under testing in tip/out-of-tree for about a week:
>>
>> | commit ee901dc1b9ab94a37ba2efc296fe9ba72bc75adf
>> | Author:     H. Peter Anvin <hpa@zytor.com>
>> | AuthorDate: Tue Jun 24 23:03:48 2008 +0200
>> | Commit:     Ingo Molnar <mingo@elte.hu>
>> | CommitDate: Wed Jun 25 18:48:13 2008 +0200
>> |
>> |     x86 ACPI: normalize segment descriptor register on resume
>>
>> no problems caused by it so far.
>>
>
> Here is the incremental patch which should stick "strictly to the script" 
> of ljmp immediately after writing CR0.PE.  This should be done to the boot 
> code as well; I'm waiting for confirmation from the Elan original reporter 
> before submitting that patch.
>
> I decided to make this an incremental patch to make it bisectable versus 
> the other one, however, it should probably be considered the right thing.
>
> Note: I have not tested this beyond compilation, I'm afraid.

I had to apply it by hand, then I tested it along with Rafael's patch
and it does not seem to break anything here. So feel free to add my
ACK to both.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-07-01  9:18 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 23:48 [RFT] x86 acpi: normalize segment descriptor register on resume Rafael J. Wysocki
     [not found] ` <200807010148.02135.rjw-KKrjLPT3xs0@public.gmane.org>
2008-07-01  0:05   ` H. Peter Anvin
2008-07-01  6:31   ` Ingo Molnar
     [not found]     ` <20080701063133.GC16642-X9Un+BFzKDI@public.gmane.org>
2008-07-01  6:54       ` H. Peter Anvin
2008-07-01  9:19         ` Pavel Machek [this message]
2008-07-01 20:39         ` Rafael J. Wysocki
2008-07-01 20:42           ` Andi Kleen
2008-07-01 20:50             ` Rafael J. Wysocki
2008-07-01 20:52               ` Andi Kleen
     [not found]             ` <486A96C1.2020106-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>
2008-07-12  6:29               ` Andy Lutomirski
2008-07-12 12:08                 ` Andi Kleen
     [not found]                   ` <48789EC3.2070701-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>
2008-07-12 15:08                     ` Andy Lutomirski
     [not found]                 ` <48784F51.1010407-YSGFQ8SKJZVDPfheJLI6IQ@public.gmane.org>
2008-07-12 18:51                   ` Rafael J. Wysocki
2008-07-12 20:31                     ` Andy Lutomirski
2008-07-12 20:47                       ` Rafael J. Wysocki
2008-07-12 20:39                     ` Andy Lutomirski
2008-07-12 20:53                       ` Rafael J. Wysocki
2008-07-12 23:11                         ` Andy Lutomirski
2008-07-12 23:33                           ` Rafael J. Wysocki
2008-07-13  8:56                             ` Pavel Machek
2008-07-13 18:16                               ` H. Peter Anvin
2008-07-14  6:36                                 ` Pavel Machek
2008-07-13  9:15                             ` Ingo Molnar
2008-07-13 12:02                               ` Matthew Garrett
2008-07-13 15:50                                 ` Andy Lutomirski
2008-07-13 18:43                                   ` Andi Kleen
2008-07-13 19:15                                     ` Rafael J. Wysocki
2008-07-13 20:11                                       ` Andi Kleen
2008-07-13 20:29                                         ` Rafael J. Wysocki
2008-07-14  2:35                                           ` H. Peter Anvin
2008-07-14 20:10                                             ` Rafael J. Wysocki
2008-07-13 20:38                                         ` H. Peter Anvin
2008-07-14  1:31                                           ` Matthew Garrett
2008-07-14  4:18                                           ` H. Peter Anvin
2008-07-14  7:39                                             ` Pavel Machek
2008-07-14 20:09                                             ` Rafael J. Wysocki
2008-07-16 14:13                                             ` Andrew Lutomirski
2008-07-16 14:23                                               ` Ingo Molnar
2008-07-13 20:16                                     ` H. Peter Anvin
2008-07-13 20:21                                       ` Andi Kleen
2008-07-13 20:32                                         ` Rafael J. Wysocki
2008-07-14  1:22                                         ` Henrique de Moraes Holschuh
2008-07-14  6:14                                           ` Pavel Machek
2008-07-14 11:22                                             ` Henrique de Moraes Holschuh
2008-07-13 18:02                                 ` Rafael J. Wysocki
2008-07-01  7:02       ` H. Peter Anvin
2008-07-01 13:01         ` Andi Kleen
2008-07-01 15:55           ` H. Peter Anvin
     [not found]             ` <486A5378.7020601-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2008-07-01 16:21               ` Andi Kleen
2008-07-01 17:28                 ` H. Peter Anvin
2008-07-01  7:20 ` Ingo Molnar
     [not found]   ` <20080701072024.GB26601-X9Un+BFzKDI@public.gmane.org>
2008-07-01  7:28     ` Andrew Morton
2008-07-01  7:45       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-07-12 23:07 H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080701091937.GA1871@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).