From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] Panasonic Let's Note laptop extras driver Date: Thu, 3 Jul 2008 18:08:57 +0100 Message-ID: <20080703170857.GA30135@srcf.ucam.org> References: <20080702090044.GB12272@prithivi.gnumonks.org> <20080702101919.GB699@srcf.ucam.org> <20080703165219.GE4172@prithivi.gnumonks.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:46184 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbYGCRJB (ORCPT ); Thu, 3 Jul 2008 13:09:01 -0400 Content-Disposition: inline In-Reply-To: <20080703165219.GE4172@prithivi.gnumonks.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Harald Welte Cc: linux-acpi@vger.kernel.org, Hiroshi Miura , hadi@cyberus.ca On Fri, Jul 04, 2008 at 12:52:19AM +0800, Harald Welte wrote: > So I vote for keeping those events in the driver - just as long as there > is no new standard mechanism for signalling brightness up/down button > events to userspace. There is - they should just be sent as KEY_BRIGHTNESSUP and KEY_BRIGHTNESSDOWN. -- Matthew Garrett | mjg59@srcf.ucam.org