Re: [linux-pm] [RFC PATCH 2/4] ACPI: introduce the mechanism to save/restore ACPI NVS memory

Pavel Machek
2008-07-09T14:38:23Z

Hi!

> > static int acpi_hibernation_begin(void)
> > {
> > acpi_target_sleep_state = ACPI_STATE_S4;
> >
> > - return 0;
> > + /* allocate pages for ACPI NVS memory before swsusp_shrink_memory */
> > + return acpi_allocate_nvs_pages();
>
> I think we shouldn't abort hibernation because of that.
>
> This may be an emergency hibernation due to critical battery status and we
> surely don't want to about that.

I disagree here. If spec says 'you must save this', and we don't, we
are asking for subtle, dangerous, and very hard to repoduce problems.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html