Re: [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers

Thomas Renninger
2008-07-09T16:00:32Z

...
> For this to work, the ACPI video driver needs to work as it currently
> does. It is not correct for it to disable itself on IGD systems.
Right, now I got it. It is only the T61/Lenovo you must have the opregion
driver ready or you better fallback to thinkpad_acpi...
Is that correct?
I will add a dmi check for Lenovo in video_detect.c.
That would be:
- If ACPI Appendix B video brightness functions are found
| -> use video.ko
| |
| -> If it's a ThinkPad, check for Opregion BIOS support
| -> Use video.ko if IGD parts are implemented (and the one
| | ThinkPad specific func you had the 750ms delay is available)
| -> otherwise go back to thinkpad_acpi
|
-> Use vendor specific driver

FWIW, the IGD part to switch to vendor specific drivers can be deleted anyway
if you say the IGD parts are working with your upcoming patches.

This would then be to use video.ko when detecting general brightness functions
and otherwise let vendor specific drivers do it. No IGD check is necessary at
all anymore.
The check for IGD was because ThinkPads did not work with video.ko then and
this blocked the "check for physical graphics device" patch fixing a lot
others.

Please also provide an OSI string with your video opregion code parts, so that
BIOS can check whether the kernel is capable of serving IGD devices. Just
choose a random string you like, e.g. let OSI("Opregion Video Support")
return true.

Thomas