From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
ak@linux.intel.com, Len Brown <lenb@kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RESEND] [PATCH -next 2/2] acpi,rfkill,backlight: comapl-laptop update - use rfkill switch subsystem
Date: Wed, 9 Jul 2008 22:12:01 -0300 [thread overview]
Message-ID: <20080710011201.GC15729@khazad-dum.debian.net> (raw)
In-Reply-To: <200807092357.28013.IvDoorn@gmail.com>
On Wed, 09 Jul 2008, Ivo van Doorn wrote:
> It is not mandatory if you are writing rfkill support for a driver that does not
> come with a rfkill switch. Such drivers can make use of the rfkill events produced
> by the hardware which does have such a switch.
>
> When the hardware does have the rfkill switch, then yes rfkill_force_state() is mandatory.
> The get_state() callback function is optional, and allows rfkill to differentiate
> between soft and hardblock.
Do you want me to mark rfkill_force_state() as mandatory in the docs? It
*IS* the preferred way to deal with firmware/hardware-initiated state
changes, after all.
The rfkill subsystem will limp along without it, even when there are
hardware rfkill lines... but no OSD function will work, as the system will
pick up the change only when someone reads or writes to the state
attribute...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-07-10 1:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 21:10 [RESEND] [PATCH -next 2/2] acpi,rfkill,backlight: comapl-laptop update - use rfkill switch subsystem Cezary Jackiewicz
2008-07-09 21:33 ` Ivo van Doorn
2008-07-09 21:44 ` Cezary Jackiewicz
2008-07-09 21:57 ` Ivo van Doorn
2008-07-10 1:12 ` Henrique de Moraes Holschuh [this message]
2008-07-10 13:17 ` Ivo van Doorn
2008-07-10 13:29 ` Henrique de Moraes Holschuh
2008-07-10 1:07 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710011201.GC15729@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cezary.jackiewicz@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox