From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@suse.cz>,
pm list <linux-pm@lists.linux-foundation.org>,
Shaohua Li <shaohua.li@intel.com>, Len Brown <lenb@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH -mm 4/8] serio: Speed-up resume
Date: Thu, 10 Jul 2008 02:01:55 +0200 [thread overview]
Message-ID: <200807100201.56232.rjw@sisk.pl> (raw)
In-Reply-To: <200807100152.17755.rjw@sisk.pl>
From: Shaohua Li <shaohua.li@intel.com>
Subject: serio: Speed-up resume
serio_resume will call into psmouse_extensions(). In my test, the
routine is very slow, it blocks resume about 1 sec. Below patch (move
resume to kseriod, just like boot time probe) cures the issue in my
test, and seems no side effect. I'm no familiar with serio driver, so
please check.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Acked-by: Len Brown <lenb@kernel.org>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/input/serio/serio.c | 33 +++++++++++++++++++++++++--------
1 file changed, 25 insertions(+), 8 deletions(-)
Index: linux-next/drivers/input/serio/serio.c
===================================================================
--- linux-next.orig/drivers/input/serio/serio.c
+++ linux-next/drivers/input/serio/serio.c
@@ -163,6 +163,7 @@ enum serio_event_type {
SERIO_RECONNECT_PORT,
SERIO_REGISTER_PORT,
SERIO_ATTACH_DRIVER,
+ SERIO_RESUME_PORT,
};
struct serio_event {
@@ -287,6 +288,13 @@ static struct serio_event *serio_get_eve
return event;
}
+#ifdef CONFIG_PM
+static void serio_resume_port(struct device *dev);
+#else
+static inline void serio_resume_port(struct device *dev)
+{
+}
+#endif /* CONFIG_PM */
static void serio_handle_event(void)
{
struct serio_event *event;
@@ -319,6 +327,10 @@ static void serio_handle_event(void)
serio_attach_driver(event->object);
break;
+ case SERIO_RESUME_PORT:
+ serio_resume_port(event->object);
+ break;
+
default:
break;
}
@@ -925,21 +937,26 @@ static int serio_suspend(struct device *
return 0;
}
-static int serio_resume(struct device *dev)
+static void serio_resume_port(struct device *dev)
{
struct serio *serio = to_serio_port(dev);
- if (dev->power.power_state.event != PM_EVENT_ON &&
- serio_reconnect_driver(serio)) {
- /*
- * Driver re-probing can take a while, so better let kseriod
- * deal with it.
- */
- serio_rescan(serio);
+ if (serio_reconnect_driver(serio)) {
+ serio_disconnect_port(serio);
+ serio_find_driver(serio);
}
dev->power.power_state = PMSG_ON;
+}
+static int serio_resume(struct device *dev)
+{
+ /*
+ * Driver reconnect can take a while, so better let kseriod
+ * deal with it.
+ */
+ if (dev->power.power_state.event != PM_EVENT_ON)
+ serio_queue_event(dev, NULL, SERIO_RESUME_PORT);
return 0;
}
#endif /* CONFIG_PM */
next prev parent reply other threads:[~2008-07-10 0:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 23:52 [PATCH -mm 0/8] PM patches for 2.6.27 Rafael J. Wysocki
2008-07-09 23:55 ` [PATCH -mm 1/8] PM: Add new PM_EVENT codes for runtime power transitions Rafael J. Wysocki
2008-07-10 11:34 ` Pavel Machek
2008-07-09 23:58 ` [PATCH -mm 2/8] AHCI: Speed-up resume Rafael J. Wysocki
2008-07-10 11:34 ` Pavel Machek
2008-07-10 0:00 ` [PATCH -mm 3/8] Hibernation: Simplify memory bitmap Rafael J. Wysocki
2008-07-10 11:34 ` Pavel Machek
2008-07-10 0:01 ` Rafael J. Wysocki [this message]
2008-07-10 11:35 ` [PATCH -mm 4/8] serio: Speed-up resume Pavel Machek
2008-07-10 15:11 ` Dmitry Torokhov
2008-07-10 0:03 ` [PATCH -mm 5/8] Introduce new interface schedule_work_on Rafael J. Wysocki
2008-07-10 11:36 ` Pavel Machek
2008-07-10 0:04 ` [PATCH -mm 6/8] Schedule sysrq poweroff on boot cpu Rafael J. Wysocki
2008-07-10 11:36 ` Pavel Machek
2008-07-10 0:05 ` [PATCH -mm 7/8] ACPI hibernation: Utilize hardware signature Rafael J. Wysocki
2008-07-10 8:34 ` Pavel Machek
2008-07-10 0:07 ` [PATCH -mm 8/8] ACPI PM: Add DMI quirk list for ACPI 1.0 suspend ordering Rafael J. Wysocki
2008-07-10 11:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807100201.56232.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@suse.cz \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox