Re: [PATCH 10/11] thinkpad_acpi: fingers off backlight if video.ko is serving this functionality

Henrique de Moraes Holschuh
2008-07-16T13:38:42Z

On Wed, 16 Jul 2008, Matthew Garrett wrote:
> On Wed, Jul 16, 2008 at 09:40:44AM -0300, Henrique de Moraes Holschuh wrote:
> > One question: is there a good reason to actually have the hotkey
> > handling for IGD mode directly in thinkpad-acpi? We don't do it for
> > Vista BIOS, video.ko doesn't do it either (anymore)... and I would make
> > it configurable for IBM firmware if I could.
>
> No. There's no reason to have IGD handling in thinkpad-acpi at all.

Then please leave that part out of the final patch. It will make the
patch a LOT simpler (no need to muck with anything hotkey_*).

But the observation about extending brightness_mode to
force-select/unselect igdmode stands anyway.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh