Re: Check for ACPI backlight support otherwise use vendor ACPI drivers - version 2

Jonathan Woithe
2008-07-31T00:36:28Z

Hi Thomas

> > On mer, 2008-07-16 at 12:52 +0200, Thomas Renninger wrote:
> > > It is highly recommended that these patches are tried out together with
> > > Matthew's/Hong's IGD driver changes.
> > > I do not know whether they are already in the dri tree or in linux-next,
> > > whether they will be accepted for .27 etc. I hope Matthew will answer on
> > > this mail and tell us.
> > > AFAIK on thinkpads they already need an additional patch to work?
> > > Chances are high that other laptop families also need a bit of a special
> > > treatment to get the very new IGD parts to work.
> > > If people test both patches together we could get a matrix like this:
> >
> > What is the status of those patches wrt. 2.6.27-rc1?
>
> Matthew and Rui accepted or signed them off AFAIK.
> On Peter's system (nokos@gmx.de, fujitsu with IGD support) it returns that
> there is no video support which looks wrong.
> I contacted him a bit late, after getting pointed to acpidump it still looks
> odd/wrong, and I need acpi.debug_level=0x1f log_buf_len=16777216 output to
> hopefully see what it is.
>
> A comment from Andi/Len would be great.
> Maybe this could already be sent to linux-next to make testing easier.
> :
> PS: and this is version 2, I already sent version 3 which had some cleanups.

I'm trying to sort out the status of this myself. Is the expectation that
your patches *with* the IGD work from Matthew/Hong should mean that Fujitsus
implementing IGD should not need fujitsu-laptop in order to provide working
software backlight brightness control? Or shouldn't Matthew/Hong's
patchset be necessary with your patch in theory?

AFAIK even IGD Fujitsus will need fujitsu-laptop to support other hotkeys,
so allowing fujitsu-laptop to co-exist with video.ko handling the backlight
(as your patches allow) is the right thing to do.

Regards
jonathan