Re: [PATCH 10/11] thinkpad_acpi: fingers off backlight if video.ko is serving this functionality

Andi Kleen
2008-07-17T09:10:52Z

Matthew Garrett wrote:
> On Wed, Jul 16, 2008 at 05:27:55PM +0200, Thomas Renninger wrote:
>> On Wednesday 16 July 2008 15:38:39 Henrique de Moraes Holschuh wrote:
>>> On Wed, 16 Jul 2008, Matthew Garrett wrote:
>>>> On Wed, Jul 16, 2008 at 09:40:44AM -0300, Henrique de Moraes Holschuh
>> wrote:
>>>>> One question: is there a good reason to actually have the hotkey
>>>>> handling for IGD mode directly in thinkpad-acpi? We don't do it for
>>>>> Vista BIOS, video.ko doesn't do it either (anymore)... and I would make
>>>>> it configurable for IBM firmware if I could.
>>>> No. There's no reason to have IGD handling in thinkpad-acpi at all.
>> I haven't seen the video driver on a T61 with Intel card doing proper
>> backlight switching on the correct device yet.
>
> The patch is queued and will be in 2.6.27. It's fine.

I admit I have lost track of the state of these patches. If there's an
agreed subset of patches that should go in post .27 via ACPI please
resend them for review.

Thanks,

-Andi