From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Alex Chiang <achiang@hp.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] fix warning in pci_slot
Date: Mon, 28 Jul 2008 15:05:47 -0700 [thread overview]
Message-ID: <200807281505.47467.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080722205602.GA7657@ldl.fc.hp.com>
On Tuesday, July 22, 2008 1:56 pm Alex Chiang wrote:
> * Matthew Wilcox <matthew@wil.cx>:
> > I get warnings about 'device' possibly being used uninitialised. While I
> > can deduce this is not true, it seems that GCC can't. This patch changes
> > `check_slot' to return device on success and -1 on error, which shuts
> > GCC up.
> >
> > Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
>
> Perhaps a more meaningful patch title, like:
>
> fix bogus "'device' may be used uninitialized" warning in pci_slot
>
> But otherwise,
>
> Acked-by: Alex Chiang <achiang@hp.com>
Applied, thanks.
Jesse
prev parent reply other threads:[~2008-07-28 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 18:37 [PATCH] fix warning in pci_slot Matthew Wilcox
2008-07-22 20:56 ` Alex Chiang
2008-07-28 22:05 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807281505.47467.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=achiang@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox