* Debug interface used for error message cleanups
@ 2008-07-30 20:22 Thomas Renninger
2008-07-30 20:22 ` [PATCH 1/9] ACPI cm_sbs: Debug interface used for error message cleanup Thomas Renninger
` (9 more replies)
0 siblings, 10 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore
This removes all DB_WARN and DB_ERROR instances from the kernel.
It is still one time used in ACPICA code in the namespace dir.
It would be great to remove this from ACPICA to finally avoid
people from mis-using it.
Patches are compile tested.
Hmm, there seem to be a compile error in the wireless area, but
my touched files have compiled already, no time to look
at this right now, I expect it's known already:
CC [M] drivers/net/wireless/iwlwifi/iwl-led.o
drivers/net/wireless/iwlwifi/iwl-led.c: In function âiwl_led_brightness_setâ:
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: âled_type_strâ undeclared (first use in this function)
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
make[4]: *** [drivers/net/wireless/iwlwifi/iwl-led.o] Error 1
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/9] ACPI cm_sbs: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 2/9] ACPI memhotplug: " Thomas Renninger
` (8 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/cm_sbs.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/cm_sbs.c b/drivers/acpi/cm_sbs.c
index f9db4f4..58dc367 100644
--- a/drivers/acpi/cm_sbs.c
+++ b/drivers/acpi/cm_sbs.c
@@ -52,8 +52,7 @@ struct proc_dir_entry *acpi_lock_ac_dir(void)
if (acpi_ac_dir) {
lock_ac_dir_cnt++;
} else {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Cannot create %s\n", ACPI_AC_CLASS));
+ printk(KERN_ERR "Cannot create %s\n", ACPI_AC_CLASS);
}
mutex_unlock(&cm_sbs_mutex);
return acpi_ac_dir;
@@ -83,8 +82,7 @@ struct proc_dir_entry *acpi_lock_battery_dir(void)
if (acpi_battery_dir) {
lock_battery_dir_cnt++;
} else {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Cannot create %s\n", ACPI_BATTERY_CLASS));
+ printk(KERN_ERR "Cannot create %s\n", ACPI_BATTERY_CLASS);
}
mutex_unlock(&cm_sbs_mutex);
return acpi_battery_dir;
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/9] ACPI memhotplug: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
2008-07-30 20:22 ` [PATCH 1/9] ACPI cm_sbs: Debug interface used for error message cleanup Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 3/9] ACPI processor: " Thomas Renninger
` (7 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/acpi_memhotplug.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 5f1127a..36e51ff 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -454,8 +454,8 @@ static int acpi_memory_device_start (struct acpi_device *device)
/* call add_memory func */
result = acpi_memory_enable_device(mem_device);
if (result)
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Error in acpi_memory_enable_device\n"));
+ printk(KERN_ERR "Error in "
+ "acpi_memory_enable_device\n");
}
return result;
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/9] ACPI processor: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
2008-07-30 20:22 ` [PATCH 1/9] ACPI cm_sbs: Debug interface used for error message cleanup Thomas Renninger
2008-07-30 20:22 ` [PATCH 2/9] ACPI memhotplug: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 4/9] ACPI video: " Thomas Renninger
` (6 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/processor_perflib.c | 21 ++++++++++-----------
drivers/acpi/processor_throttling.c | 17 ++++++-----------
2 files changed, 16 insertions(+), 22 deletions(-)
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index b474996..f643068 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -512,14 +512,13 @@ static int acpi_processor_get_psd(struct acpi_processor *pr)
}
psd = buffer.pointer;
- if (!psd || (psd->type != ACPI_TYPE_PACKAGE)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _PSD data\n"));
- result = -EFAULT;
- goto end;
- }
-
- if (psd->package.count != 1) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _PSD data\n"));
+ if (!psd || (psd->type != ACPI_TYPE_PACKAGE)
+ || psd->package.count != 1) {
+ /*
+ * ToDo: Mark it as BIOS bug as soon as there is an interface
+ * for it
+ */
+ printk(KERN_ERR "Invalid _PSD data\n");
result = -EFAULT;
goto end;
}
@@ -532,19 +531,19 @@ static int acpi_processor_get_psd(struct acpi_processor *pr)
status = acpi_extract_package(&(psd->package.elements[0]),
&format, &state);
if (ACPI_FAILURE(status)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _PSD data\n"));
+ ACPI_ERROR((DB_INFO, status, "Invalid _PSD data\n"));
result = -EFAULT;
goto end;
}
if (pdomain->num_entries != ACPI_PSD_REV0_ENTRIES) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Unknown _PSD:num_entries\n"));
+ printk(KERN_ERR "Unknown _PSD:num_entries\n");
result = -EFAULT;
goto end;
}
if (pdomain->revision != ACPI_PSD_REV0_REVISION) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Unknown _PSD:revision\n"));
+ printk(KERN_ERR "Unknown _PSD:revision\n"));
result = -EFAULT;
goto end;
}
diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
index 0622ace..95de498 100644
--- a/drivers/acpi/processor_throttling.c
+++ b/drivers/acpi/processor_throttling.c
@@ -527,14 +527,9 @@ static int acpi_processor_get_tsd(struct acpi_processor *pr)
}
tsd = buffer.pointer;
- if (!tsd || (tsd->type != ACPI_TYPE_PACKAGE)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _TSD data\n"));
- result = -EFAULT;
- goto end;
- }
-
- if (tsd->package.count != 1) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _TSD data\n"));
+ if (!tsd || (tsd->type != ACPI_TYPE_PACKAGE)
+ || tsd->package.count != 1) {
+ printk(KERN_INFO "Invalid _TSD data\n");
result = -EFAULT;
goto end;
}
@@ -547,19 +542,19 @@ static int acpi_processor_get_tsd(struct acpi_processor *pr)
status = acpi_extract_package(&(tsd->package.elements[0]),
&format, &state);
if (ACPI_FAILURE(status)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _TSD data\n"));
+ ACPI_ERROR(DB_INFO, status, "Invalid _TSD data\n"));
result = -EFAULT;
goto end;
}
if (pdomain->num_entries != ACPI_TSD_REV0_ENTRIES) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Unknown _TSD:num_entries\n"));
+ printk(KERN_ERR "Unknown _TSD:num_entries\n"));
result = -EFAULT;
goto end;
}
if (pdomain->revision != ACPI_TSD_REV0_REVISION) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Unknown _TSD:revision\n"));
+ printk(KERN_ERR "Unknown _TSD:revision\n"));
result = -EFAULT;
goto end;
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/9] ACPI video: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (2 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 3/9] ACPI processor: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 5/9] ACPI scan: " Thomas Renninger
` (5 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/video.c | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 7abd326..90ab74a 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -1540,8 +1540,8 @@ acpi_video_bus_get_one_device(struct acpi_device *device,
acpi_video_device_notify,
data);
if (ACPI_FAILURE(status)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Error installing notify handler\n"));
+ ACPI_EXCEPTION((DB_INFO, status,
+ "Error installing notify handler\n"));
if(data->brightness)
kfree(data->brightness->levels);
kfree(data->brightness);
@@ -1755,8 +1755,7 @@ acpi_video_bus_get_devices(struct acpi_video_bus *video,
status = acpi_video_bus_get_one_device(dev, video);
if (ACPI_FAILURE(status)) {
- ACPI_DEBUG_PRINT((ACPI_DB_WARN,
- "Cant attach device"));
+ printk(KERN_ERR "Cant attach device [%d]\n", status);
continue;
}
}
@@ -2013,8 +2012,8 @@ static int acpi_video_bus_add(struct acpi_device *device)
ACPI_DEVICE_NOTIFY,
acpi_video_bus_notify, video);
if (ACPI_FAILURE(status)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Error installing notify handler\n"));
+ ACPI_EXCEPTION((DB_INFO, status,
+ "Error installing notify handler\n"));
error = -ENODEV;
goto err_stop_video;
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/9] ACPI scan: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (3 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 4/9] ACPI video: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 6/9] ACPI fan: " Thomas Renninger
` (4 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/scan.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 2dcb953..ffbf8f6 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -113,15 +113,15 @@ static int acpi_bus_hot_remove_device(void *context)
if (acpi_bus_trim(device, 1)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Removing device failed\n"));
+ printk(KERN_ERR "Removing device [%s] failed\n",
+ acpi_device_bid(device));
return -1;
}
/* power off device */
status = acpi_evaluate_object(handle, "_PS3", NULL, NULL);
if (ACPI_FAILURE(status) && status != AE_NOT_FOUND)
- ACPI_DEBUG_PRINT((ACPI_DB_WARN,
+ ACPI_EXCEPTION((DB_INFO, status,
"Power-off device failed\n"));
if (device->flags.lockable) {
@@ -477,7 +477,8 @@ static int acpi_device_register(struct acpi_device *device,
result = acpi_device_setup_files(device);
if(result)
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Error creating sysfs interface for device %s\n", device->dev.bus_id));
+ printk(KERN_ERR "Error creating sysfs interface for device"
+ " %s [%d]\n", device->dev.bus_id), result);
device->removal_type = ACPI_BUS_REMOVAL_NORMAL;
return 0;
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 6/9] ACPI fan: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (4 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 5/9] ACPI scan: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 7/9] ACPI osl: " Thomas Renninger
` (3 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/fan.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index 55c17af..e3fa9a5 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -327,8 +327,7 @@ static int acpi_fan_resume(struct acpi_device *device)
result = acpi_bus_get_power(device->handle, &power_state);
if (result) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Error reading fan power state\n"));
+ printk("Error reading fan power state [%d]\n", result);
return result;
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 7/9] ACPI osl: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (5 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 6/9] ACPI fan: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 8/9] ACPI thermal: " Thomas Renninger
` (2 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/osl.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index bf42ef1..0841c07 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -729,8 +729,7 @@ acpi_status acpi_os_execute(acpi_execute_type type,
INIT_WORK(&dpc->work, acpi_os_execute_deferred);
queue = (type == OSL_NOTIFY_HANDLER) ? kacpi_notify_wq : kacpid_wq;
if (!queue_work(queue, &dpc->work)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Call to queue_work() failed.\n"));
+ printk(KERN_ERR "Call to queue_work() failed.\n");
status = AE_ERROR;
kfree(dpc);
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 8/9] ACPI thermal: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (6 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 7/9] ACPI osl: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:22 ` [PATCH 9/9] ACPI system: " Thomas Renninger
2008-07-30 20:29 ` Debug interface used for error message cleanups Moore, Robert
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/thermal.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index db6c2a5..c40b041 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -1214,8 +1214,7 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz)
acpi_bus_private_data_handler,
tz->thermal_zone);
if (ACPI_FAILURE(status)) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Error attaching device data\n"));
+ ACPI_ERROR((DB_INFO, status, "Error attaching device data\n"));
return -ENODEV;
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 9/9] ACPI system: Debug interface used for error message cleanup
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (7 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 8/9] ACPI thermal: " Thomas Renninger
@ 2008-07-30 20:22 ` Thomas Renninger
2008-07-30 20:29 ` Debug interface used for error message cleanups Moore, Robert
9 siblings, 0 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-30 20:22 UTC (permalink / raw)
To: ak; +Cc: lenb, linux-acpi, robert.moore, Thomas Renninger
Signed-off-by: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/system.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/system.c b/drivers/acpi/system.c
index d8e3f15..d007793 100644
--- a/drivers/acpi/system.c
+++ b/drivers/acpi/system.c
@@ -386,8 +386,8 @@ static ssize_t counter_set(struct kobject *kobj,
goto end;
if (!(all_counters[index].flags & ACPI_EVENT_VALID)) {
- ACPI_DEBUG_PRINT((ACPI_DB_WARN,
- "Can not change Invalid GPE/Fixed Event status\n"));
+ printk(KERN_WARN
+ "Can not change Invalid GPE/Fixed Event status\n");
return -EINVAL;
}
--
1.5.4.5
^ permalink raw reply related [flat|nested] 17+ messages in thread
* RE: Debug interface used for error message cleanups
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
` (8 preceding siblings ...)
2008-07-30 20:22 ` [PATCH 9/9] ACPI system: " Thomas Renninger
@ 2008-07-30 20:29 ` Moore, Robert
2008-07-30 20:55 ` Andi Kleen
2008-07-31 9:59 ` Thomas Renninger
9 siblings, 2 replies; 17+ messages in thread
From: Moore, Robert @ 2008-07-30 20:29 UTC (permalink / raw)
To: Thomas Renninger, ak; +Cc: lenb, linux-acpi
I'm going to go ahead and remove these from ACPICA.
We added an "obsolete" warning in the header file some time ago, and I think the time has come to remove them, especially in light of these patches to Linux.
Bob
>-----Original Message-----
>From: Thomas Renninger [mailto:trenn@suse.de]
>Sent: Wednesday, July 30, 2008 1:22 PM
>To: ak@linux.intel.com
>Cc: lenb@kernel.org; linux-acpi@vger.kernel.org; Moore, Robert
>Subject: Debug interface used for error message cleanups
>
>This removes all DB_WARN and DB_ERROR instances from the kernel.
>
>It is still one time used in ACPICA code in the namespace dir.
>It would be great to remove this from ACPICA to finally avoid
>people from mis-using it.
>
>Patches are compile tested.
>
>Hmm, there seem to be a compile error in the wireless area, but
>my touched files have compiled already, no time to look
>at this right now, I expect it's known already:
> CC [M] drivers/net/wireless/iwlwifi/iwl-led.o
>drivers/net/wireless/iwlwifi/iwl-led.c: In function
>‘iwl_led_brightness_set’:
>drivers/net/wireless/iwlwifi/iwl-led.c:198: error: ‘led_type_str’
>undeclared (first use in this function)
>drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared
>identifier is reported only once
>drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it
>appears in.)
>make[4]: *** [drivers/net/wireless/iwlwifi/iwl-led.o] Error 1
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Debug interface used for error message cleanups
2008-07-30 20:29 ` Debug interface used for error message cleanups Moore, Robert
@ 2008-07-30 20:55 ` Andi Kleen
2008-07-31 9:59 ` Thomas Renninger
1 sibling, 0 replies; 17+ messages in thread
From: Andi Kleen @ 2008-07-30 20:55 UTC (permalink / raw)
To: Moore, Robert; +Cc: Thomas Renninger, lenb, linux-acpi
Moore, Robert wrote:
> I'm going to go ahead and remove these from ACPICA.
>
> We added an "obsolete" warning in the header file some time ago, and I think the time has come to remove them, especially in light of these patches to Linux.
Ok I'll get these patches back from ACPICA with the next merge then.
-Andi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Debug interface used for error message cleanups
2008-07-30 20:29 ` Debug interface used for error message cleanups Moore, Robert
2008-07-30 20:55 ` Andi Kleen
@ 2008-07-31 9:59 ` Thomas Renninger
2008-07-31 21:42 ` Moore, Robert
2008-08-01 1:42 ` Zhang Rui
1 sibling, 2 replies; 17+ messages in thread
From: Thomas Renninger @ 2008-07-31 9:59 UTC (permalink / raw)
To: Moore, Robert; +Cc: ak, lenb, linux-acpi, rui.zhang
On Wednesday 30 July 2008 22:29:19 Moore, Robert wrote:
> I'm going to go ahead and remove these from ACPICA.
>
> We added an "obsolete" warning in the header file some time ago, and I
> think the time has come to remove them, especially in light of these
> patches to Linux.
Great thanks.
If you are at that, do you think it makes sense to intruduce a GPE
bit?
Just leaving it unused for now?
I didn't play with these much yet, Rui, do you think this makes sense? The
fact there were several sever problems recently and GPEs possibly
must get debugged by people writting other device drivers who do not know
and do not want to know about the output of the other debug flags I thought
this could make sense.
Just an idea...,
Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: Debug interface used for error message cleanups
2008-07-31 9:59 ` Thomas Renninger
@ 2008-07-31 21:42 ` Moore, Robert
2008-08-01 1:42 ` Zhang Rui
1 sibling, 0 replies; 17+ messages in thread
From: Moore, Robert @ 2008-07-31 21:42 UTC (permalink / raw)
To: Thomas Renninger; +Cc: ak, lenb, linux-acpi, Zhang, Rui
>If you are at that, do you think it makes sense to intruduce a GPE
>bit?
How about something a bit more generic - ACPI_DB_EVENTS. This could be
used for both the fixed events and the GPEs.
>-----Original Message-----
>From: Thomas Renninger [mailto:trenn@suse.de]
>Sent: Thursday, July 31, 2008 2:59 AM
>To: Moore, Robert
>Cc: ak@linux.intel.com; lenb@kernel.org; linux-acpi@vger.kernel.org;
Zhang,
>Rui
>Subject: Re: Debug interface used for error message cleanups
>
>On Wednesday 30 July 2008 22:29:19 Moore, Robert wrote:
>> I'm going to go ahead and remove these from ACPICA.
>>
>> We added an "obsolete" warning in the header file some time ago, and
I
>> think the time has come to remove them, especially in light of these
>> patches to Linux.
>
>Great thanks.
>If you are at that, do you think it makes sense to intruduce a GPE
>bit?
>Just leaving it unused for now?
>
>I didn't play with these much yet, Rui, do you think this makes sense?
The
>fact there were several sever problems recently and GPEs possibly
>must get debugged by people writting other device drivers who do not
know
>and do not want to know about the output of the other debug flags I
thought
>this could make sense.
>
>Just an idea...,
>
> Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Debug interface used for error message cleanups
2008-07-31 9:59 ` Thomas Renninger
2008-07-31 21:42 ` Moore, Robert
@ 2008-08-01 1:42 ` Zhang Rui
2008-08-01 9:01 ` Thomas Renninger
1 sibling, 1 reply; 17+ messages in thread
From: Zhang Rui @ 2008-08-01 1:42 UTC (permalink / raw)
To: Thomas Renninger; +Cc: Moore, Robert, ak, lenb, linux-acpi
On Thu, 2008-07-31 at 17:59 +0800, Thomas Renninger wrote:
> On Wednesday 30 July 2008 22:29:19 Moore, Robert wrote:
> > I'm going to go ahead and remove these from ACPICA.
> >
> > We added an "obsolete" warning in the header file some time ago, and
> I
> > think the time has come to remove them, especially in light of these
> > patches to Linux.
>
> Great thanks.
> If you are at that, do you think it makes sense to intruduce a GPE
> bit?
> Just leaving it unused for now?
>
> I didn't play with these much yet, Rui, do you think this makes sense?
> The
> fact there were several sever problems recently and GPEs possibly
> must get debugged by people writting other device drivers who do not
> know
> and do not want to know about the output of the other debug flags I
> thought
> this could make sense.
We used to get the GPE debug info by doing this,
set debug_layer=0x44, debug_level=0x8800001f
We can get the content of GPE Block Register once a GPE is fired.
and it's the same for PM1 Event Register and Fixed Events.
Is this what you want?
thanks,
rui
>
> Just an idea...,
>
> Thomas
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Debug interface used for error message cleanups
2008-08-01 1:42 ` Zhang Rui
@ 2008-08-01 9:01 ` Thomas Renninger
2008-08-01 15:45 ` Moore, Robert
0 siblings, 1 reply; 17+ messages in thread
From: Thomas Renninger @ 2008-08-01 9:01 UTC (permalink / raw)
To: Zhang Rui; +Cc: Moore, Robert, ak, lenb, linux-acpi
On Friday 01 August 2008 03:42:24 Zhang Rui wrote:
> On Thu, 2008-07-31 at 17:59 +0800, Thomas Renninger wrote:
> > On Wednesday 30 July 2008 22:29:19 Moore, Robert wrote:
> > > I'm going to go ahead and remove these from ACPICA.
> > >
> > > We added an "obsolete" warning in the header file some time ago, and
> >
> > I
> >
> > > think the time has come to remove them, especially in light of these
> > > patches to Linux.
> >
> > Great thanks.
> > If you are at that, do you think it makes sense to intruduce a GPE
> > bit?
> > Just leaving it unused for now?
> >
> >
> > I didn't play with these much yet, Rui, do you think this makes sense?
> > The
> > fact there were several sever problems recently and GPEs possibly
> > must get debugged by people writting other device drivers who do not
> > know
> > and do not want to know about the output of the other debug flags I
> > thought
> > this could make sense.
>
> We used to get the GPE debug info by doing this,
> set debug_layer=0x44, debug_level=0x8800001f
> We can get the content of GPE Block Register once a GPE is fired.
> and it's the same for PM1 Event Register and Fixed Events.
> Is this what you want?
Ahh yes:
ACPI_LV_INTERRUPTS 0x08000000
ACPI_LV_EVENTS 0x80000000
I think this is what I am looking for.
Thanks,
Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: Debug interface used for error message cleanups
2008-08-01 9:01 ` Thomas Renninger
@ 2008-08-01 15:45 ` Moore, Robert
0 siblings, 0 replies; 17+ messages in thread
From: Moore, Robert @ 2008-08-01 15:45 UTC (permalink / raw)
To: Thomas Renninger, Zhang, Rui; +Cc: ak, lenb, linux-acpi
There is currently no corresponding ACPI_DB_EVENTS to go with
ACPI_LV_EVENTS, I will add it.
Meaning, of course, that ACPI_LV_EVENTS is currently unused.
>-----Original Message-----
>From: Thomas Renninger [mailto:trenn@suse.de]
>Sent: Friday, August 01, 2008 2:01 AM
>To: Zhang, Rui
>Cc: Moore, Robert; ak@linux.intel.com; lenb@kernel.org; linux-
>acpi@vger.kernel.org
>Subject: Re: Debug interface used for error message cleanups
>
>On Friday 01 August 2008 03:42:24 Zhang Rui wrote:
>> On Thu, 2008-07-31 at 17:59 +0800, Thomas Renninger wrote:
>> > On Wednesday 30 July 2008 22:29:19 Moore, Robert wrote:
>> > > I'm going to go ahead and remove these from ACPICA.
>> > >
>> > > We added an "obsolete" warning in the header file some time ago,
and
>> >
>> > I
>> >
>> > > think the time has come to remove them, especially in light of
these
>> > > patches to Linux.
>> >
>> > Great thanks.
>> > If you are at that, do you think it makes sense to intruduce a GPE
>> > bit?
>> > Just leaving it unused for now?
>> >
>> >
>> > I didn't play with these much yet, Rui, do you think this makes
sense?
>> > The
>> > fact there were several sever problems recently and GPEs possibly
>> > must get debugged by people writting other device drivers who do
not
>> > know
>> > and do not want to know about the output of the other debug flags I
>> > thought
>> > this could make sense.
>>
>> We used to get the GPE debug info by doing this,
>> set debug_layer=0x44, debug_level=0x8800001f
>> We can get the content of GPE Block Register once a GPE is fired.
>> and it's the same for PM1 Event Register and Fixed Events.
>> Is this what you want?
>Ahh yes:
>ACPI_LV_INTERRUPTS 0x08000000
>ACPI_LV_EVENTS 0x80000000
>
>I think this is what I am looking for.
>Thanks,
>
> Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2008-08-01 15:46 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-30 20:22 Debug interface used for error message cleanups Thomas Renninger
2008-07-30 20:22 ` [PATCH 1/9] ACPI cm_sbs: Debug interface used for error message cleanup Thomas Renninger
2008-07-30 20:22 ` [PATCH 2/9] ACPI memhotplug: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 3/9] ACPI processor: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 4/9] ACPI video: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 5/9] ACPI scan: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 6/9] ACPI fan: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 7/9] ACPI osl: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 8/9] ACPI thermal: " Thomas Renninger
2008-07-30 20:22 ` [PATCH 9/9] ACPI system: " Thomas Renninger
2008-07-30 20:29 ` Debug interface used for error message cleanups Moore, Robert
2008-07-30 20:55 ` Andi Kleen
2008-07-31 9:59 ` Thomas Renninger
2008-07-31 21:42 ` Moore, Robert
2008-08-01 1:42 ` Zhang Rui
2008-08-01 9:01 ` Thomas Renninger
2008-08-01 15:45 ` Moore, Robert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox