Re: [PATCH] Add Intel ACPI IGD OpRegion support

Yves-Alexis Perez
2008-08-05T21:47:54Z

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

On mar, 2008-08-05 at 21:44 +0200, Yves-Alexis Perez wrote:
> On mar, 2008-08-05 at 19:37 +0100, Matthew Garrett wrote:
> > This adds the support necessary for allowing ACPI backlight control
> > to
> > work on some newer Intel-based graphics systems. Tested on Thinkpad
> > T61
> > and HP 2510p hardware.
>
> Ok, I managed to apply it against drm-2.6/drm-next but it won't apply
> against linux-acpi-2.6/test and I'm not sure how hard it is to cherry
> pick the needed stuff from drm to acpi.
>
> I'll try to build the drm-2.6/drm-next + patch but I guess it won't be
> enough to test brightness keys?

Ok, I checked out drm-2.6/drm-next, created a local branch drm-next and
applied OpRegion.
Then I checked out linux-acpi-2.6/test, created a local branched, and
merged then my local drm-next into it.

Built fine, rebooted into single user (without using acpi_backlight=).
In single user, brightness keys still don't work.

In booted into X (with hal, powersaved, dbus etc. running), and then,
tada, brightness keys work. There is a 750ms (I guess) delay, and I
don't know who is really responsible, I guess X is. (and thus I guess
the opregion is the one needed, and X manages the brightness. If the
kernel was, it would be working even in single user)

Hope that can help understand the issues. Feel free to ask more info.

Cheers,
--
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]