Re: [PATCH] Add Intel ACPI IGD OpRegion support

Henrique de Moraes Holschuh
2008-08-06T02:32:54Z

On Wed, 06 Aug 2008, Matthew Garrett wrote:
> On Tue, Aug 05, 2008 at 11:47:54PM +0200, Yves-Alexis Perez wrote:
> > In booted into X (with hal, powersaved, dbus etc. running), and then,
> > tada, brightness keys work. There is a 750ms (I guess) delay, and I
> > don't know who is really responsible, I guess X is. (and thus I guess
> > the opregion is the one needed, and X manages the brightness. If the
> > kernel was, it would be working even in single user)
>
> The 750ms delay is from thinkpad-acpi. I sent a patch to Henrique which
> makes it go away, but I'm not entirely sure what the ACPI method
> concerned is supposed to be doing. The opregion code won't currently run
> until X is started because the drm layer requires X to be the foreground
> vt before handling IRQs.

Well, for what is it worth, thinkpad-acpi has a knob (brightness_mode) which
can be used. Set it to CMOS mode (see docs). From what I recall, it should
do what your patch does.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh