Re: [RESEND] [PATCH 2/4] ACPI: Get the device power state in the course of scanning device

Zhao Yakui
2008-08-11T10:07:26Z

On Mon, 2008-08-11 at 09:56 +0200, Andi Kleen wrote:
> > After the patch is applied, Linux will still do the power state check
> > unless the boot option of "acpi.power_nocheck=1" is added. In such case
> > it won't affect anything.
>
> Understood that.
>
> > In fact we expect that the boot option of "acpi.power_nocheck=1" becomes
> > the default. But we will have to wait for more response. Only after more
> > tests are done, it will be OK.
>
> Ok.
>
> > what the init sequence ordering for .27 means?
>
> The first patch moved acpi_device_set_context to be earlier, so
> the init sequence is different. All the other changes are optional,
> as in conditional on the flag, but that one is not.
Although the acpi_device_set_context is moved to the earlier in the
first patch, it won't break anything. In the patch the acpi device is
bound with the acpi handle before getting the flag of Power
management/Wakeup/Performance.
Maybe it can be put to the acpi test tree to test whether it will break
anything.
Thanks.

> I have not been completely able to satisfy myself that it is low
> risk enough.
>
> -Andi