public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Machek <pavel@suse.cz>
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, trivial@kernel.org
Subject: Re: acpi: trivial cleanups
Date: Tue, 12 Aug 2008 16:20:13 -0700	[thread overview]
Message-ID: <20080812162013.b139035b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080812102434.GA2676@elf.ucw.cz>

On Tue, 12 Aug 2008 12:24:34 +0200
Pavel Machek <pavel@suse.cz> wrote:

> 
> Trivial cleanups for ACPI. Fix misspelling in printk(), fix mismerge,
> add file header.
> 
>
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -123,7 +123,7 @@ struct acpi_processor_errata errata __re
>  static int set_no_mwait(const struct dmi_system_id *id)
>  {
>  	printk(KERN_NOTICE PREFIX "%s detected - "
> -		"disable mwait for CPU C-stetes\n", id->ident);
> +		"disabling mwait for CPU C-states\n", id->ident);
>  	idle_nomwait = 1;
>  	return 0;

OK

> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 283c08f..cf5b1b7 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -41,7 +41,6 @@ #include <linux/sched.h>	/* need_resched
>  #include <linux/pm_qos_params.h>
>  #include <linux/clockchips.h>
>  #include <linux/cpuidle.h>
> -#include <linux/cpuidle.h>

OK

>  /*
>   * Include the apic definitions for x86 to have the APIC timer related defines
> diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
> index a6b662c..b4d9cb3 100644
> --- a/drivers/acpi/reboot.c
> +++ b/drivers/acpi/reboot.c
> @@ -1,4 +1,8 @@
> -
> +/*
> + * Reset the machine using the RESET_REG
> + *
> + * Distribute under GPL.
> + */

That was a trivial dirtyup.  Should at least be "Distributed under the
GPL" but I suspect that the policy in drivers/acpi/ is to add fancier
copyright text than this.



  reply	other threads:[~2008-08-12 23:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-12 10:24 acpi: trivial cleanups Pavel Machek
2008-08-12 23:20 ` Andrew Morton [this message]
2008-08-13 12:45   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080812162013.b139035b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox